The ROLE cache mode does use the concatenation of the all the roles a user has. In various cases however, all that is needed is a different cash hash for anonymous and authenticated users. Patch adds this as an option for the panels submodule.
Note : this superseeds #2220445: esi_panels_url does not pass the CACHE mode in url

CommentFileSizeAuthor
#3 esi-authenticated_cache_mode-2232217-3.patch4.01 KBsgdev
#2 add_authenticated_cache_mode-2232217-2.patch3.51 KBbellesmanieres
#1 add_authenticated_cache_mode-2232217.patch3.28 KBbellesmanieres

Comments

bellesmanieres’s picture

bellesmanieres commented
StatusFileSize
new add_authenticated_cache_mode-2232217.patch3.28 KB
bellesmanieres’s picture

bellesmanieres commented
StatusFileSize
new add_authenticated_cache_mode-2232217-2.patch3.51 KB

Forgot a needed bit !

sgdev’s picture

sgdev commented
StatusFileSize
new esi-authenticated_cache_mode-2232217-3.patch4.01 KB

There is a problem with the patch in #2.

In the esi_panels__esi_pane_prepare function, it says, "The cache mode is always the last argument, then the url." However, in the esi_panels_url function, the code to add the cache mode is placed before the current page URL, not after it. The attached patch changes this order so it can work properly.

Also there is a typo in the ESI_PANELS_CACHE_AUTHENTICATED label, and I don't understand the naming of hook_boot as "tmw_caching_boot"? Have changed this to be esi_panels_boot.

Please review the attached patch, thanks.

dstuart’s picture

dstuart commented
Status: Needs review » Reviewed & tested by the community
dstuart’s picture

dstuart commented
Status: Reviewed & tested by the community » Fixed

Pushed to 7.3

  • dstuart committed 736ec51 on 7.x-3.x authored by ron_s 
    Issue #2232217 by bellesmanieres, ron_s: Add a cache mode for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.