In moving from references module to entityreference was missing the formatter for displaying the URL which can be handy in the context of using for tokens.

CommentFileSizeAuthor
#8 entityreference-dev-2370029-reroll.patch2.21 KBnigelcunningham
#2 url_formatter-2370029-2-7.x-1.5.patch2.3 KBpasan.gamage
#1 entityreference-url-formatter-2370029-1-7.x-1.1.patch2.69 KBgrom358

Comments

grom358’s picture

grom358 commented
Status: Active » Needs review
StatusFileSize
new entityreference-url-formatter-2370029-1-7.x-1.1.patch2.69 KB
pasan.gamage’s picture

pasan.gamage commented
Version: 7.x-1.1 » 7.x-1.5
StatusFileSize
new url_formatter-2370029-2-7.x-1.5.patch2.3 KB

Adding 7.x-1.5 patch

Status: Needs review » Needs work

The last submitted patch, 2: url_formatter-2370029-2-7.x-1.5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tobybellwood’s picture

tobybellwood commented

Resubmitted to test queue as was failing b/c https://www.drupal.org/node/2903006

Tests now passing

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
tobybellwood’s picture

tobybellwood commented
Status: Needs review » Reviewed & tested by the community

We've reviewed, tested and deployed this at https://github.com/govCMS/govCMS/pull/549

minoroffense’s picture

minoroffense commented
Status: Reviewed & tested by the community » Needs work

I'm all for this functionality but I'd like to see some test cases created before merging. Or you could conceivably split this into its own module.

nigelcunningham’s picture

nigelcunningham commented
StatusFileSize
new entityreference-dev-2370029-reroll.patch2.21 KB

Adding a reroll that fixes a reject against current dev.

govind.maloo’s picture

govind.maloo commented
Status: Needs work » Reviewed & tested by the community

Patch is working fine. This should be move to RTBC.

minoroffense’s picture

minoroffense commented
Status: Reviewed & tested by the community » Needs work

Still no tests so it's not RTBC