Node access performance issue after update

I confirm the performance issue.

If there is 300 nodes in the entityreference select form, there will be 300 node_access calls and 300 more queries...

The commit #1 needs to be reverted.

I changed the issue as Major, because the module is not usable if you have 10 or more entityReferencable nodes.

Just posting to confirm the problem. The node load time prior to this update was less than 0.5 seconds and jumped to more than 3 minutes after the update... all other factors equal. We will be reverting this change in our test environment and post back with updates.

I forgot to come back to this, but reverting the commit does resolve the issue. We are using entity reference heavily with hundreds of nodes that can be referenced in a field collection (literally thousands of node_access checks).

Could the node_access check be executed only on change? For example, if I have rights to edit the content, load the Edit page as expected, then execute node-access only if I modify or add an entityreference?

Whatever happened with this?

This is still an issue.

Entity reference is doing node_access check in:

$has_view_access = (entity_access('view', $target_type, $target_entities[$item[$column]]) !== FALSE);
$has_update_access = (entity_access('update', $target_type, $target_entities[$item[$column]]) !== FALSE);
$items[$id][$delta]['access'] = ($has_view_access || $has_update_access);

in entityreference_field_formatter_prepare_view

In some point it have sense but when You prepare view and You don't use any referenced items it simply check all referenced nodes what doesn't make any sense if any of them is not in use. It simply is not aware of that situation. We have ex. one node to be referenced by hundreds other and performance will go down to few minutes from few seconds.

We have to use custom hack to turn off this check for views.

Witch some very advanced caching (we use that ones - we cache node_access for some minutes) You may not fell it until this cache will have to be cleaned. So our users has been use view it work fine until they do not make some changes and cache have to be cleaned what make them very frustrated as it was taking a lot time to recheck all accesses.

This need more work. Maybe simple option or hook to control it will fix it.