Tests are failing on the latest dev versions of core 8.3.x and err 8.x-1.x.

I found the core commit that caused this to start happening:

http://cgit.drupalcode.org/drupal/commit/?id=8dc87c9

It hides the "Create New Revision" checkbox on the node edit form when creating a new node.

CommentFileSizeAuthor
#7 test_settings.png42.49 KBjmuzz
#2 err-fix_tests-2817871-2.patch1.81 KBjmuzz

Comments

jmuzz created an issue. See original summary.

jmuzz’s picture

jmuzz commented
Status: Active » Needs review
StatusFileSize
new err-fix_tests-2817871-2.patch1.81 KB
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Does this also work with 8.2?
We should not yet commit 8.3 specific things to head.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community
jmuzz’s picture

jmuzz commented

It looks like testbot did tests on 8.2 for this patch and they passed.

If you don't want to commit it you should change the project's test settings because all the 8.3.x testbot runs on this module will fail until it gets fixed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

@jmuzz that setting unfortunately doesn't exist ;) You can do single test runs against other versions but not change the default.

I think miro overlooked that this only affects node add forms, where the checkbox is bogus and will obviously always result in a new revision. This will definitely get committed.

jmuzz’s picture

jmuzz commented
StatusFileSize
new test_settings.png42.49 KB

It seems like a logical change to me too. For what it's worth I think the project administrators can stop it from running tests on 8.3.x if they set up the test settings page like this.

jmuzz’s picture

jmuzz commented

Nope you're right that's something else entirely. My bad.

jmuzz’s picture

jmuzz commented
jmuzz’s picture

jmuzz commented

It makes me wonder though... If you can't stop it from testing against 8.3.x, what would you do if you don't need your module to be compatible with 8.3.x but are just shooting for 8.2.x compatibility like Miro suggests? Just leave it as an unsolved critical issue until 8.3.x gets released and let all the tests in the issue queue fail until then?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

@jmuzz No, Miro didn't suggest that. You misunderstood him.

I'm just not blindly committing things to make 8.3 pass, because it could break 8.2.
I'm perfectly happy with 8.3 first, but we always need to make sure 8.2 as a stable maintenance goal is stable.
Thus committing 8.3 SPECIFIC things (that will break 8.2) are absolutely forbidden on HEAD. Because a release of Paragraphs prior to the 8.3 core release would break Paragraphs for all regular users.
For instance in Diff module, you can see how users are confused about the compatibility problem:
#2818815: 8.x-1.0-beta2 is not compatible with Drupal 8.1.x

Comitted. Like Berdir said, now i understand this fix seems correct for 8.2 and 8.3, so i'm happy.

jmuzz’s picture

jmuzz commented

Oh I misunderstood. I wouldn't want to do anything that breaks 8.2 either.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.