Only works for menu items defined by menu module [#2669874]

I know this is by design, but it is causing problems for my use case. Would it perhaps be possible to instead exclude system menu items, because I guess that is the real reason behind the check? Here is a patch to make the change.

Comment	File	Size	Author
#4	entity_menu_links-exclude-system-2669874-3.patch	4.04 KB	gnucifer
#2	entity_menu_links-exclude-system-2669874-2.patch	4.64 KB	gnucifer

Comments

Comment #1

16 February 2016 at 16:46

gnucifer created an issue. See original summary.

Comment #2

gnucifer commented 16 February 2016 at 16:47

Status	File	Size
new	entity_menu_links-exclude-system-2669874-2.patch	4.64 KB

Comment #3

gnucifer commented 16 February 2016 at 16:48

Status:

Active

» Needs review

Comment #4

gnucifer commented 20 April 2016 at 11:00

Status	File	Size
new	entity_menu_links-exclude-system-2669874-3.patch	4.04 KB

Re-rolled against current HEAD.

Comment #5

vj commented 14 February 2017 at 06:14

@gnucifer

Patch works for me. But do we need all system menu items to deploy? I think it will be great if we can add vid based on "menu name" like navigation menu we don't want to push, generally we use main menu & user menu only. So only these modules should have vid assigned. Please share your thoughts. Let me know if any help required to re-roll the patch.

Comment #6

vj commented 14 February 2017 at 06:17

Status:

Needs review

» Needs work

@gnucifer

Also this patch doesn't work if module already installed. We have to add this code snippet in update hook.

Comment #7

dineshw commented 14 February 2017 at 09:33

Hi Vj / gnucifer: I believe its fine to make menus deployable, as far as it carry configuration parameters like weight , menu title, menu attribute if any.

Patch should consider update hook if it needs to work for existing menu items as well.