Problem/Motivation

Change record: https://www.drupal.org/node/3260849

Steps to reproduce

Proposed resolution

use getPrefix() method if available and fallback to tablePrefix() for older version of core

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_hierarchy-3403718

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

el7cosmos created an issue. See original summary.

el7cosmos opened merge request !25

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos at PreviousNext commented
Status: Active » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Can we make use of this new helper here instead? https://www.drupal.org/node/3371619

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos at PreviousNext commented

That is only available in >=10.1.

If we want to change the version constraint, say release a new version that require core ^10.1, we might as well replace the method call altogether as the `getPrefix` also introduced in 10.1.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Ah didn't realise - thanks

Happy to do that, 10.0 is nearly EOL

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

Getting these pop up with Symfony bridge / deprecation helper since during entity updates the deprecation is triggered. e.g:

entity_hierarchy_entity_update->ParentEntityReactionBase->\Drupal\entity_hierarchy\Storage\NestedSetStorageFactory::__construct

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Needs work

Let's bump the minimum version to 10.1 and remove the method_exists dance - thanks!

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Assigned: Unassigned » dpi
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Assigned: dpi » Unassigned
Status: Needs work » Needs review

10.1 minimum, update usage to use new method exclusively.

  • larowlan committed 58521c57 on 3.x authored by el7cosmos 
    Issue #3403718 by el7cosmos, dpi, larowlan: Drupal\Core\Database\...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Fixed

Thanks, will tag a new 3.x release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.