In #2350463: Previewing an entity in the WYSIWYG does not add any attached styles or javascript from the AJAX callback we added attachs/deattachs to embedded entity. To prevent strange things from happening we hardcoded list of behaviours that are not attached. It would be nice to make that list configurable.

See https://github.com/drupal-media/entity_embed/pull/103#issuecomment-60486887 for more info.

Comments

cs_shadow’s picture

cs_shadow commented

So, how much configurable are we talking here. Meaning do we just want configuration schema or also through UI?

yched’s picture

yched commented

Yeah, not sure "configurable" is the right word here, I was thinking more of making sure the list of behaviors can be adjusted for custom use cases if need be.

IMO it could be as simple as moving the list of excluded behaviors to a dedicated var in Drupal.entityEmbed, so that it can be overriden by custom JS.

cs_shadow’s picture

cs_shadow commented
Status: Active » Needs review

@yched, Thanks for clearing this up. I thought we were talking about configuration through Configuration Management system.

PR: https://github.com/drupal-media/entity_embed/pull/113

Based on what @yched suggested in #2.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Merged. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.