There are several minor improvements that could be made to the Clone Confirmation form.
- The Clone button should be blue (the default button) - was already implemented in #3050974: Implement form actions wrapper for consistent theming and improved form_alter'ing
- It should be wrapped in an actions wrapper to fix margins on the buttons. - was already implemented in #3050974: Implement form actions wrapper for consistent theming and improved form_alter'ing
- The Abort button could be renamed to "Cancel" to match other confirmation forms.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | entity-clone-form-button-style-changes-3068549-3.patch | 509 bytes | alphin |
| Screenshot from 2019-07-17 15-47-44.png | 20.5 KB | quicksketch | |
| Screenshot from 2019-07-17 15-47-51.png | 29.86 KB | quicksketch |
Comments
Comment #2
alphin commentedComment #3
alphin commentedPlease review this patch
Comment #4
idebr commentedItem 1 and 3 were already implemented in #3050974: Implement form actions wrapper for consistent theming and improved form_alter'ing
Comment #5
deaom commentedComment #6
deaom commentedI tested the patch provided under #3 and it changes the Abort text to Cancel, so marking this as RTBC.
Comment #8
colanThanks all.