Problem/Motivation

The EntityCloneForm displays submit buttons for 'Clone' and 'Abort', but these buttons are not wrapped in an actions wrapper. Form actions are always rendered at the button of a form. Admin themes can implement styling for these actions.

An actions wrapper also makes it easier to add elements to the form through hook_form_alter() since you do not have to add a #weight property to make sure the elements are rendered before the submit buttons.

Proposed resolution

Implement form actions wrapper for consistent theming and improved form_alter'ing.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The Clone-button is rendered as a primary submit button.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 entity_clone-actions_wrapper-3050974-2.patch1.17 KBidebr
#2 EntityCloneForm-after.png55.24 KBidebr
#2 EntityCloneForm-before.png53.83 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new EntityCloneForm-before.png53.83 KB
new EntityCloneForm-after.png55.24 KB
new entity_clone-actions_wrapper-3050974-2.patch1.17 KB

Attached patch implements a form actions wrapper for consistent theming and improved form_alter'ing.

Before

After

  • vpeltot committed 971fc25 on 8.x-1.x authored by idebr 
    Issue #3050974 by idebr: Implement form actions wrapper for consistent...
vpeltot’s picture

vpeltot commented
Status: Needs review » Fixed

Commited. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.