Problem/Motivation

The current implementation explicitly looks for the entity browser dialog trigger to be of type <input />. This makes the entity browser not usable e.g. when a theme relys on <button /> elements to be used for all buttons.

Proposed resolution

  • Look for <button /> elements, too - use :input instead if input in jQuery selectors

Remaining tasks

  • Provide a patch to fix the issue

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 also_allow_button-2826226-3.patch1.65 KBhctom
#2 also_allow_button-2826226-2.patch0 byteshctom

Comments

hctom created an issue. See original summary.

hctom’s picture

hctom
Primary language German
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new also_allow_button-2826226-2.patch0 bytes

Attached you can find the patch that should solve the issue.

Status: Needs review » Needs work

The last submitted patch, 2: also_allow_button-2826226-2.patch, failed testing.

The last submitted patch, 2: also_allow_button-2826226-2.patch, failed testing.

hctom’s picture

hctom
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new also_allow_button-2826226-3.patch1.65 KB

Woops, somehow the patch was empty in the last attempt. So here is the correct patch file.

sanja_m’s picture

sanja_m commented
Status: Needs review » Reviewed & tested by the community

Patch seems OK.

rajab natshah’s picture

rajab natshah
he/him
commented

+1 Much better.

slashrsm’s picture

slashrsm commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +D8Media

Committed. Thanks!

  • slashrsm committed cb246a0 on 8.x-1.x authored by hctom 
    Issue #2826226 by hctom, sanja_m: Make selector for modal display...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.