“defaultUri” (camelCase) or “defaultURI” (uppercase acronym)? Entity API uses both in different files!

Basically:

• defaultUri() (camelCase) appears three times in “…/entity/includes/entity.inc”:
  • Defined as a protected function defaultUri() { … in line #312,
  • Invoked in line #307 as return $this->defaultUri(); , and…
  • Mentioned in the documenting comment in line #177
• Yet defaultURI() (uppercase acronym) exists in “…/entity/tests/entity_test.module” defined as a protected function defaultURI() { … in line #159!

This has caused some confusion among developers of other modules, such as the Group module which in its GProfile submodule uses the uppercase-acronym defaultURI throughout, which results in a Javascript error as reported in [#2874940].

I think this needs to be patched here in your “…/entity/includes/entity.inc” to simply create a deprecated, not-intended-to-be-used but intended only to catch such errors uppercase-URL protected function that simply calls the existing camelCase version, like so (inserted starting at line #319):

  /**
   * MMCC: DO NOT use this! Added only for compatibility with some modules that had misspelled “defaultUri” (camelCase)!
   */
  protected function defaultURI() { ///MMCC: DO NOT use this! Added only for compatibility with some modules that had misspelled “defaultUri”!
    return $this->defaultUri();
  }