Closed (fixed)
Project:
Email Registration
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Nov 2019 at 11:26 UTC
Updated:
28 Jan 2020 at 19:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
saidatomComment #3
saidatomComment #4
saidatomComment #5
gregglesThanks for your help!
Testing says that the patch failed to apply and I tried manually and it failed to apply, so marking as needs work.
Comment #6
saidatomComment #7
saidatomComment #8
gregglesMoving to needs work for the test fail.
Comment #9
saidatomComment #10
saidatomComment #11
saidatomComment #12
saidatomComment #13
andypostexcept this duplicated calls to assertSession() better use local var
Comment #14
andypostThe patch mixing "Link" as render object and string to use for translation - reverted.
Also a bit of clean-up
Comment #15
andypostAnd the check should be against start theme, so better check for own error message
Comment #16
andypostI gonna commit it and polish remains in #3037323: Remove usage of deprecated methods and functions
Comment #18
andypostAfter deprecations new release is unlocked