Comments

saidatom created an issue. See original summary.

saidatom’s picture

saidatom’s picture

Title: Fix error form_state » Change the way how translation is made
saidatom’s picture

greggles’s picture

Status: Needs review » Needs work

Thanks for your help!

Testing says that the patch failed to apply and I tried manually and it failed to apply, so marking as needs work.

saidatom’s picture

saidatom’s picture

Status: Needs work » Needs review
greggles’s picture

Status: Needs review » Needs work

Moving to needs work for the test fail.

saidatom’s picture

StatusFileSize
new5.6 KB
saidatom’s picture

saidatom’s picture

andypost’s picture

+++ b/tests/src/Functional/EmailRegistrationTestCase.php
@@ -37,41 +38,41 @@ class EmailRegistrationTestCase extends BrowserTestBase {
+    $this->assertSession()->responseContains('Enter your email address.');
+    $this->assertSession()->responseContains('Email');
+    $this->assertSession()->responseNotContains('Email or username');

except this duplicated calls to assertSession() better use local var

andypost’s picture

Status: Needs work » Needs review
StatusFileSize
new7.86 KB
new10.31 KB

The patch mixing "Link" as render object and string to use for translation - reverted.
Also a bit of clean-up

andypost’s picture

StatusFileSize
new970 bytes
new10.37 KB

And the check should be against start theme, so better check for own error message

andypost’s picture

Status: Needs review » Reviewed & tested by the community

I gonna commit it and polish remains in #3037323: Remove usage of deprecated methods and functions

  • andypost committed 12ca6ae on 8.x-1.x
    Issue #3093666 by saidatom, andypost: Change the way how translation is...
andypost’s picture

Status: Reviewed & tested by the community » Fixed

After deprecations new release is unlocked

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.