It appears none of the install scripts have uninstall hooks implemented, so I took the liberty to add some. Basically it's clean-up code to drop tables so that the user can permanently remove a module from the database. Also means that using a tool like 'devel' does not require manual dropping of the tables.

I implemented the hook for the following EC modules:
- address
- cart
- contrib/ec_region
- contrib/flexicharge
- ec_anon
- file
- invoice
- parcel
- payment
- paypal
- product
- shipping
- store
- subproducts
- tangible
- tax

Also note that the patch fixes a table name typo for PGSQL in the shipping module.

CommentFileSizeAuthor
hook_uninstall.patch11.33 KBjerryjvl

Comments

gordon’s picture

Status: Needs review » Fixed

Thanks I have commited this to HEAD.

gordon’s picture

Status: Fixed » Patch (to be ported)

Can this patch please be ported to the new DRUPAL-5--3 branch

gordon’s picture

Version: master » 5.x-3.x-dev
grsingleton’s picture

I will give it a go. The patch looks very much like what I have and am preparing so will restart with this on. If there are variables that should also be deleted when uninstalling so one can get a clean start I would like to know these as well. So far I have not found anything that seems to apply but I am wary that variables could prevent the install scripts from executing.

sime’s picture

Component: -- other -- » installation

fixing component

gordon’s picture

Version: 5.x-3.x-dev » 5.x-4.x-dev
Status: Patch (to be ported) » Fixed

backported to v4

dries’s picture

Status: Fixed » Closed (fixed)