Problem/Motivation

The D12 changes merged into 3.2.2 added a PHP8.3 requirement.
Composer still says >= 8.1, but in dynamic_entity_reference.info.yml it now requires 8.3.
https://git.drupalcode.org/project/dynamic_entity_reference/-/blob/3.2.2...

We are still updating are servers (to 8.4) so we ran into this while deploying to a server still running 8.2.
At first glance it seems to work fine, but the error got people a little stressed over here.

CommentFileSizeAuthor
#4 3612331-remove-duplicate-php-requirement.patch445 bytesdkmishra

Issue fork dynamic_entity_reference-3612331

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

r.van.doorn created an issue. See original summary.

r.van.doorn’s picture

r.van.doorn commented
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Tests are still passing on D10 on 8.1 so I think you're OK.

I think the best path forward would be a new release that removed the entry from .info.yml and updated composer.json so its only in one spot

dkmishra’s picture

dkmishra commented
StatusFileSize
new 3612331-remove-duplicate-php-requirement.patch445 bytes

Attached a patch that removes the duplicate php: 8.3 entry from dynamic_entity_reference.info.yml per comment #3 — the version requirement now lives only in composer.json. Verified it applies cleanly against 3.x-dev.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

@dkmishra any chance you could open an MR for that change 🙏

dkmishra opened merge request !60

dkmishra’s picture

dkmishra commented

Hi @larowlan,
I've opened the MR. Thanks!

dkmishra’s picture

dkmishra commented
Version: 3.2.2 » 3.x-dev
Status: Active » Needs review

  • larowlan committed 5d35cb31 on 3.x authored by dkmishra 
    fix: #3612331 Module requires php 8.3 after automated D12 changes

By: r...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

Thanks @dkmishra 🙌

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

https://www.drupal.org/project/dynamic_entity_reference/releases/3.2.3

The one where dkmishra fixed a PHP version requirement mismatch 🐘

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.