Problem/Motivation
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork dynamic_entity_reference-3377096
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
acbramley commentedhttps://git.drupalcode.org/project/dynamic_entity_reference/-/merge_requ... for some reason this isn't linked to this issue.
Comment #8
larowlanFixed the MR, it was in the project group (i.e. the actual repo) not the issues fork (i.e where MRs should go).
Deleted the extra branch from the actual repo.
Comment #10
jibranThe remaining fails are 10.2 PHPUnit so going to merge this as is for now as CS, ES, and Stan are green.
Comment #12
jibranMoving to 4.x.
Comment #14
larowlanI was working on phpunit here too - is there another issue for that?
Comment #15
larowlanI'll open a new MR for phpunit
Comment #16
jibranNW for figuring out the way to create triggers on gitlabCI.
Comment #17
jibranRE #15: Thank you.
There is #3384721: Fix fatals on 10.2 caused by the field UI changes but up to you.
Comment #18
jibranSorted out triggers on gitlab ci.
Comment #20
jibranBack to Lee for fixing the test fails.
Comment #21
jibranRemoved drupalci test runs. Will create a follow up to remove drupalci and circleci files.
Comment #22
larowlanI'm working in #3384721: Fix fatals on 10.2 caused by the field UI changes
Comment #23
larowlanIssue credits
Comment #24
damienmckennaMind if I ask why the normalizer was removed from the 3.x branch?
Comment #25
larowlanDid an issue get added to hal module to add it over there?
Comment #26
jibranYes, #3414197: Add DynamicEntityReferenceItemNormalizer.
It has been removed from both 3.x and 4.x. Hal is not in core anymore. It can provide the service as optional with tests instead of DER changing the container run time to add the service optional.