Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jibran created an issue. See original summary.

acbramley’s picture

larowlan changed the visibility of the branch 3377096-der-fix-gitlab to active.

larowlan changed the visibility of the branch 3377096-der-fix-gitlab to hidden.

larowlan changed the visibility of the branch 3377096-der-fix-gitlab to active.

larowlan’s picture

Fixed the MR, it was in the project group (i.e. the actual repo) not the issues fork (i.e where MRs should go).

Deleted the extra branch from the actual repo.

jibran’s picture

Status: Active » Reviewed & tested by the community

The remaining fails are 10.2 PHPUnit so going to merge this as is for now as CS, ES, and Stan are green.

  • jibran committed c55f31de on 3.x
    Issue #3377096 by jibran: [DER] Fix GitLab CI 
    
jibran’s picture

Version: 3.x-dev » 4.x-dev
Status: Reviewed & tested by the community » Active

Moving to 4.x.

larowlan’s picture

I was working on phpunit here too - is there another issue for that?

larowlan’s picture

I'll open a new MR for phpunit

jibran’s picture

Status: Active » Needs work

NW for figuring out the way to create triggers on gitlabCI.

jibran’s picture

jibran’s picture

Status: Needs work » Needs review

Sorted out triggers on gitlab ci.

  • jibran committed 31300096 on 4.x
    Issue #3377096 by jibran: [DER] Fix GitLab CI 
    
jibran’s picture

Status: Needs review » Active

Back to Lee for fixing the test fails.

jibran’s picture

Removed drupalci test runs. Will create a follow up to remove drupalci and circleci files.

larowlan’s picture

Status: Active » Fixed
larowlan’s picture

Issue credits

damienmckenna’s picture

Mind if I ask why the normalizer was removed from the 3.x branch?

larowlan’s picture

Did an issue get added to hal module to add it over there?

jibran’s picture

Yes, #3414197: Add DynamicEntityReferenceItemNormalizer.

It has been removed from both 3.x and 4.x. Hal is not in core anymore. It can provide the service as optional with tests instead of DER changing the container run time to add the service optional.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.