Implement DERItem::getReferenceableBundles

The method was renamed in https://www.drupal.org/project/drupal/issues/3057545#comment-13187968

Updated the patch for this change.

Given this is a static method, we should be able to test this with a unit test

Code looks good

@kfritsche I have applied the latest patch to a Drupal 9.1.10 installation but I'm still getting lots of warnings like these when flushing cache:

 [warning] The "inventory" at "node:" references the ":zone" entity type that does not exist. Please take action. ResourceTypeRepository.php:449

inventory is a base field we created in a module for various entity types, e.g. nodes, and we refer to many different other entity types and bundles from it. This is working fine in the UI and storage, but since we enabled jsonapi as well, we're getting these warnings. From the issue above I was hoping this should be fixed by the patch, but it isn't. Any hint what else could be causing this?

The blocker for this has had some movement, would be great to get some reviews on the new test coverage :)

#3057545: ResourceTypeRepository wrongly assumes that all entity reference fields have the setting "target_type" has been committed.

🥳

#5 is still pending.

Re-roll #4.

RE #5: the core issue also didn't not add tests for ::getReferenceableBundles() in #3057545: ResourceTypeRepository wrongly assumes that all entity reference fields have the setting "target_type". All the test added in that issue is for deprecation. Also unit test is going to only check that for a given mock object we have some array structure that is already being tested in DER Kernel tests so what exactly trying to test then? I'd say we should add functional tests that can help close #3027430: Dynamic Entity Reference normalization support.

HEAD is failing on 11.x atm after field UI changes. I'm working on fixing it. So ignore the test fails for now but it needs functional test and mentioned above.

This looks good to go to me

Upgraded to 10.2.0 today and got bit by this. Can we land this and tag a new release?

There are some other fails as well. Please see https://github.com/jibran/dynamic_entity_reference/pull/9. Feel free to make it green. I'm trying to find some time but no luck.

I think we can fix this and create a follow-up to fix the field settings form for DER.

I had some time to work on this today. I didn't solve it, but I did figure out where the fault lies. If you manually install DER module on 10.2 and install the inline_form_errors module, you'll see that the issue is with the new field wizard process added in 10.2.

DynamicEntityReferenceItem::storageSettingsFormValidate is triggered and we can't save the field form.

Let's see how much this fixes. I hope I got all the fixes pulled in from the referenced PR.

Hmm, can we enable gitlab integration? It looks like we are being gently nudged to move that direction as I can't run the test bot w/ 10.2 any more.

@heddn it's enabled by default now... You may need to include a .gitlab-ci.yml file, but there are instructions on doing so.

It does not however work with patches so you will need to re-roll this into an MR.

There is already a PR for it. https://git.drupalcode.org/project/dynamic_entity_reference/-/merge_requ.... It is not merged as it is not passing yet.

@jibran that MR has a lot of changes that are out of scope for getting tests passing, and seem to overlap with #3350347: Declaration of DynamicEntityReferenceItemNormalizer::normalize() must be compatible and/or #3354499: DynamicEntityReferenceItemNormalizer broken on D10 as well.

It would be great to know the list of priorities to getting DER 10.1 compatible and perhaps constrain the gitlab CI MR to just adding the pipeline and getting tests green?

NW because #20 isn't applying

I'm happy to commit #14 as is and fix the remaining fails in follow-up issue(s).

Here is the roadmap to fix 10.2 integration.

• #3057556: Implement DERItem::getReferenceableBundles
• #3384721: Fix fatals on 10.2 caused by the field UI changes
• #3413330: PHPCS fixes form Drupal 10.2

Committed and pushed #14. Thanks!