Remove dynamic_entity_reference_275136 module once #2751363: Don't allow test entities to share base table is fixed.

CommentFileSizeAuthor
#5 2555027.sh_.txt1.17 KBchx
#5 2766181_5.patch193.41 KBchx
#3 remove-2766181-3.patch198.34 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

Status: Postponed » Active
jibran’s picture

Status: Active » Needs review
StatusFileSize
new198.34 KB

In this patch:

I tried diff src/Tests/Update/der_dump-new.php src/Tests/Update/der_dump.php but the output was not useful.

Status: Needs review » Needs work

The last submitted patch, 3: remove-2766181-3.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new193.41 KB
new1.17 KB

> Link Apply pending updates does not exist on http://localhost/checkout/update.php/selection

Your update did not run at all. The .sh needed a little love to work. Attached.

Also note that re-running the script requires resetting the dynamic_entity_reference directory or just removing the dump otherwise checking out 8.x-1.x fails because the dump has changes but the script is not resilient and will continue happily....

jibran’s picture

Status: Needs review » Reviewed & tested by the community

Let's test rest of the DB drivers just for the sanity but this is ready. Thank you for fixing my stupid mistake.

  • jibran committed b96a247 on 8.x-2.x authored by chx
    Issue #2766181 by chx, jibran: Remove dynamic_entity_reference_275136
    
jibran’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.