Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Some test entities has the same base table so they share their tables, which is not something you are supposed to do because each entity can have different basefields.
Proposed resolution
Fix the base tables for test entities.
Remaining tasks
Fix the fails and review the patch.
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#5 | don_t_allow_test-2751363-5.patch | 7.1 KB | jibran |
Comments
Comment #2
jibranComment #3
jibranComment #5
jibranComment #6
BerdirThanks. This can have pretty nasty side effects in tests because it creates tables incorrectly and then you get weird exceptions.
Comment #7
BerdirI can actually reproduce this problem locally with \Drupal\Tests\system\Kernel\Extension\ModuleHandlerTest::testUninstallContentDependency, not sure why it doesn't happen for testbot?
Comment #9
jibranUnrelated fail.
Comment #11
jibranAnother unrelated fail.
Comment #13
jibranComment #14
chx CreditAttribution: chx at Smartsheet commented#2555027: Support non-numeric entity ID's is blocked by this.
Comment #16
jibranComment #18
BerdirNodeTypeTranslationTest failed. This somehow causes *a lot* of random fails. Wondering if the change has anything to do with it..
Comment #19
jibranNodeTypeTranslationTest
failed for the first time.Comment #20
alexpottCommitted and pushed 4dd3e6a5066142135cc15956035339ee89296be6 to 8.2.x and 83cc368 to 8.1.x. Thanks!
Let's hope this isn't a random fail engine.
Comment #23
jibranThanks @alexpott for committing this.