Problem/Motivation

Some test entities has the same base table so they share their tables, which is not something you are supposed to do because each entity can have different basefields.

Proposed resolution

Fix the base tables for test entities.

Remaining tasks

Fix the fails and review the patch.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 don_t_allow_test-2751363-5.patch7.1 KBjibran
#5 interdiff.txt2.43 KBjibran
#2 don_t_allow_test-2751363-2.patch4.67 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new don_t_allow_test-2751363-2.patch4.67 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: don_t_allow_test-2751363-2.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.43 KB
new don_t_allow_test-2751363-5.patch7.1 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Thanks. This can have pretty nasty side effects in tests because it creates tables incorrectly and then you get weird exceptions.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I can actually reproduce this problem locally with \Drupal\Tests\system\Kernel\Extension\ModuleHandlerTest::testUninstallContentDependency, not sure why it doesn't happen for testbot?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: don_t_allow_test-2751363-5.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

Unrelated fail.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: don_t_allow_test-2751363-5.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

Another unrelated fail.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: don_t_allow_test-2751363-5.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community
chx’s picture

chx commented
Issue tags: +Contributed project blocker

#2555027: Support non-numeric entity ID's is blocked by this.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: don_t_allow_test-2751363-5.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: don_t_allow_test-2751363-5.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

NodeTypeTranslationTest failed. This somehow causes *a lot* of random fails. Wondering if the change has anything to do with it..

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

NodeTypeTranslationTest failed for the first time.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4dd3e6a5066142135cc15956035339ee89296be6 to 8.2.x and 83cc368 to 8.1.x. Thanks!

Let's hope this isn't a random fail engine.

  • alexpott committed 4dd3e6a on 8.2.x 
    Issue #2751363 by jibran: Don't allow test entities to share base table

  • alexpott committed 83cc368 on 8.1.x 
    Issue #2751363 by jibran: Don't allow test entities to share base table...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Thanks @alexpott for committing this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.