While evaluating this module, I noticed it lacked a readme.
According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

Patch to follow, thanks!

CommentFileSizeAuthor
#4 interdiff-2979722-2-4.txt246 bytesvolkswagenchick
#4 drush_useful-add-readme-2979722-4.patch3.68 KBvolkswagenchick
#2 drush_useful-add-readme-2979722-2.patch3.71 KBvolkswagenchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
FileSize
drush_useful-add-readme-2979722-2.patch3.71 KB

I uploaded a patch that contains a useful README. Thanks!

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Status: Needs review » Needs work

Patch applied, grammar and spelling looked good. Links work as expected. But I did find one issue:

+++ b/README.md
@@ -0,0 +1,111 @@
+ * Recommended Modules

This can removed since there is no Recommended Modules

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Status: Needs work » Needs review
FileSize
drush_useful-add-readme-2979722-4.patch3.68 KB
interdiff-2979722-2-4.txt246 bytes

Thanks for the peer review. I addressed the issues in comment #3 and uploaded a new patch and interdiff for easy review.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs for DrupalFit commented

Thank you so much @volkswagenchick and @alonaoneill. I will push it after going through it once. Some of the commands will be removed as they do not work properly.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs for DrupalFit commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.