On #1599068: Ensure drupalorg_handbook works well on D7 we fixed most of the drupalorg_handbook module.

But comments were not working in the Blue* theme at the time, so I couldn't test to see whether this function was working:
drupalorg_handbook_form_comment_form_alter()

Once comments are working in the theme, we need to see if that form alter is working, and fix it if it isn't.

CommentFileSizeAuthor
#1 comment_form_alter_handbook.patch2.93 KBjhodgdon

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Postponed » Needs review
StatusFileSize
new comment_form_alter_handbook.patch2.93 KB

Comments are now working in the theme. The attached patch fixes the comment form alter so it works, and also eliminates one PHP warning.

That should take care of the drupalorg_handbook module!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I reverted and re-applied the patch, and it's working fine.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 751ef8e on 7.x-3.x, 7.x-3.x-dev authored by jhodgdon, committed by drumm: 
    [#1683804] update handbook function for comment form alter