This issue is to create the new D8 configuration for DrupalGap. Menu link created and we are checking the token with this patch.

At this point I can load the register form from the app, I can login and logout.

I'm adding here the updates and should be done on separated issues. Sorry!! :)

CommentFileSizeAuthor
#8 2382669-8.patch12.25 KBmarthinal
#8 interdiff-2382669-7-8.txt2.36 KBmarthinal
#7 interdiff-2382669-6-7.txt5.86 KBmarthinal
#7 2382669-7.patch10.84 KBmarthinal
#6 config-2382669-6.patch7 KBmarthinal
#4 2382669-4.patch5.92 KBmarthinal
#3 2382669-3.patch4.3 KBmarthinal
#1 drupalgap-config-2382669-1.patch3.72 KBmarthinal

Comments

marthinal’s picture

marthinal commented
Issue summary: View changes
Related issues: +#2381693: DrupalGap Drupal 8 PSR-4
StatusFileSize
new drupalgap-config-2382669-1.patch3.72 KB

We need to apply the patch from #2381693 and then this one.

marthinal’s picture

marthinal commented
Status: Needs review » Needs work

dataType:"html" should be "text".

marthinal’s picture

marthinal commented
StatusFileSize
new 2382669-3.patch4.3 KB

Changed dataType to "text".

Fixed path for token request.

marthinal’s picture

marthinal commented
StatusFileSize
new 2382669-4.patch5.92 KB

Added system connect operations as a new route. Not sure if here is the best place but anyway let's do this for the moment.

marthinal’s picture

marthinal commented

For the routing system _content needs to be replaced with _controller.

The json requested within the system connect probably should be obtained from Rest Resource.

marthinal’s picture

marthinal commented
StatusFileSize
new config-2382669-6.patch7 KB

The json requested within the system connect probably should be obtained from Rest Resource.

I was diving into the new rest module for d8 and I think Rest Resources are used only for entities with a canonical path.

At this point I have added a method that returns a json (systemConnect) and a method that obtains info about the current user (userSystemResources).

From the app side I can load the main default page with the menus(main,home,login...) and I have modified drupalGap app and jdrupal a little bit.

I'll try to do a pull request with these changes and hope it helps with the new version :)

So this patch is about config + system connect.

marthinal’s picture

marthinal commented
StatusFileSize
new 2382669-7.patch10.84 KB
new interdiff-2382669-6-7.txt5.86 KB

Attach js using the libraries yaml

marthinal’s picture

marthinal commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new interdiff-2382669-7-8.txt2.36 KB
new 2382669-8.patch12.25 KB

Adding register setting from Config.

marthinal’s picture

marthinal commented
Issue summary: View changes
marthinal’s picture

marthinal commented

I'm creating a new resource to register users (anonymous registration) for the d8 rest module. I think that probably system connect should be a new resource. But I'm learning how it works.

juampynr’s picture

juampynr commented

@tyler.frankenstein, please in the future respect commit authorship as it encourages more contributions. You can find details on how to do it at https://www.drupal.org/node/1146430.

tyler.frankenstein’s picture

tyler.frankenstein commented

@juampy, thanks for pointing this out. I thought placing the user name in the commit message was sufficient. I've ammended the author attribution for @marthinal.

P.S. Thanks for the RESTUI module!

P.S.S. Ha, I see drupal.org provides a template commit message to use right here in the issue key, that makes it easy!