Issue fork drupalchat-3323914

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kartiktandon created an issue. See original summary.

avpaderno’s picture

Title: Coding Standard Issues » Coding standards issues
Version: 8.x-1.0-beta2 » 8.x-1.x-dev
Assigned: kartiktandon » Unassigned
Category: Bug report » Task
Issue summary: View changes
Status: Active » Needs work
Issue tags: +Needs issue summary update

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.

avpaderno’s picture

Issue tags: +Coding standards
imustakim’s picture

Assigned: Unassigned » imustakim
imustakim’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update

Issue summary updated.

imustakim’s picture

Issue summary: View changes

imustakim’s picture

Assigned: imustakim » Unassigned

Some of the issues are fixed in MR.
These are the remaining issue.

FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/drupalchat.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 13 WARNINGS AFFECTING 17 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   8 | WARNING | Global constants should not be used, move it to a class or interface
   9 | WARNING | Global constants should not be used, move it to a class or interface
  10 | WARNING | Global constants should not be used, move it to a class or interface
  11 | WARNING | Global constants should not be used, move it to a class or interface
  13 | WARNING | Global constants should not be used, move it to a class or interface
  14 | WARNING | Global constants should not be used, move it to a class or interface
  15 | WARNING | Global constants should not be used, move it to a class or interface
  17 | WARNING | Global constants should not be used, move it to a class or interface
  18 | WARNING | Global constants should not be used, move it to a class or interface
  19 | WARNING | Global constants should not be used, move it to a class or interface
  20 | WARNING | Global constants should not be used, move it to a class or interface
  52 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.",
     |         | or "* Implements hook_foo_BAR_ID_bar() for block templates."
  97 | ERROR   | Doc comment is empty
 111 | WARNING | Line exceeds 80 characters; contains 88 characters
 120 | ERROR   | The array declaration extends to column 118 (the limit is 80). The array content should be split up over multiple lines
 355 | ERROR   | Doc comment is empty
 410 | ERROR   | Doc comment is empty
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/css/themes/light/light.css
---------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------
 245 | ERROR | Class definition is empty
 361 | ERROR | Class definition is empty
---------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/js/jquery.titlealert.min.js
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/js/swfobject.js
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/drupalchat.install
-------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-------------------------------------------------------------------------
  19 | WARNING | Line exceeds 80 characters; contains 93 characters
 113 | ERROR   | Doc comment is empty
 148 | ERROR   | Doc comment is empty
-------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/drupalchat.info.yml
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/src/Form/drupalchatSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 21 WARNINGS AFFECTING 25 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
  16 | ERROR   | Class name must begin with a capital letter
  43 | ERROR   | The array declaration extends to column 351 (the limit is 80). The array content should be split up over multiple lines
  50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  59 | WARNING | Line exceeds 80 characters; contains 150 characters
  64 | ERROR   | The array declaration extends to column 239 (the limit is 80). The array content should be split up over multiple lines
 113 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
 113 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 113 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 113 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 127 | WARNING | #options values usually have to run through t() for translation
 159 | ERROR   | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
 174 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 185 | ERROR   | The array declaration extends to column 309 (the limit is 80). The array content should be split up over multiple lines
 187 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 223 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 226 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 229 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 264 | WARNING | User::load calls should be avoided in classes, use dependency injection instead
 264 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 265 | WARNING | Unused variable $user_name.
 284 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 288 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 292 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 308 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 345 | ERROR   | Doc comment is empty
 348 | WARNING | Unused private method _drupalchat_load_themes()
 348 | ERROR   | Private method name "drupalchatSettingsForm::_drupalchat_load_themes" is not in lowerCamel format
 366 | ERROR   | Doc comment is empty
 369 | WARNING | Unused private method _drupalchat_remove_extension()
 369 | ERROR   | Private method name "drupalchatSettingsForm::_drupalchat_remove_extension" is not in lowerCamel format
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/drupalchat-3323914/src/Controller/drupalchatController.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 96 ERRORS AND 35 WARNINGS AFFECTING 123 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   15 | ERROR   | Doc comment is empty
   18 | ERROR   | Class name must begin with a capital letter
   20 | ERROR   | Doc comment is empty
   23 | ERROR   | Public method name "drupalchatController::drupalchat_verify_access" is not in lowerCamel format
   43 | WARNING | Line exceeds 80 characters; contains 81 characters
   44 | WARNING | Line exceeds 80 characters; contains 84 characters
   45 | WARNING | Line exceeds 80 characters; contains 81 characters
   53 | WARNING | Line exceeds 80 characters; contains 118 characters
   74 | ERROR   | Doc comment is empty
   77 | ERROR   | Public method name "drupalchatController::_drupalchat_get_sid" is not in lowerCamel format
   99 | ERROR   | The $_COOKIE super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->cookies->get('drupalchat_c_session') instead
  116 | ERROR   | Doc comment is empty
  119 | ERROR   | Public method name "drupalchatController::drupalchat_get_random_name" is not in lowerCamel format
  127 | ERROR   | Doc comment short description must start with a capital letter
  128 | ERROR   | Doc comment short description must end with a full stop
  128 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  130 | ERROR   | Public method name "drupalchatController::drupalchat_send" is not in lowerCamel format
  135 | ERROR   | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('form_token') instead
  136 | ERROR   | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('form_id') instead
  144 | ERROR   | The array declaration extends to column 224 (the limit is 80). The array content should be split up over multiple lines
  144 | ERROR   | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('drupalchat_message_id') instead
  144 | ERROR   | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('drupalchat_uid2') instead
  145 | ERROR   | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines
  145 | ERROR   | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('drupalchat_message') instead
  158 | ERROR   | Doc comment short description must start with a capital letter
  159 | ERROR   | Doc comment short description must end with a full stop
  159 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  161 | ERROR   | Public method name "drupalchatController::drupalchat_poll" is not in lowerCamel format
  163 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  171 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('drupalchat_last_timestamp') instead
  172 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('drupalchat_last_timestamp') instead
  182 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  190 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  200 | ERROR   | The array declaration extends to column 124 (the limit is 80). The array content should be split up over multiple lines
  206 | ERROR   | The array declaration extends to column 141 (the limit is 80). The array content should be split up over multiple lines
  210 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  215 | ERROR   | The array declaration extends to column 279 (the limit is 80). The array content should be split up over multiple lines
  218 | ERROR   | The array declaration extends to column 318 (the limit is 80). The array content should be split up over multiple lines
  226 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  227 | ERROR   | The array declaration extends to column 275 (the limit is 80). The array content should be split up over multiple lines
  228 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  236 | ERROR   | The array declaration extends to column 135 (the limit is 80). The array content should be split up over multiple lines
  237 | ERROR   | The array declaration extends to column 240 (the limit is 80). The array content should be split up over multiple lines
  238 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  239 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  246 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  247 | ERROR   | The array declaration extends to column 275 (the limit is 80). The array content should be split up over multiple lines
  248 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  256 | ERROR   | The array declaration extends to column 135 (the limit is 80). The array content should be split up over multiple lines
  257 | ERROR   | The array declaration extends to column 240 (the limit is 80). The array content should be split up over multiple lines
  258 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  259 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  281 | ERROR   | Doc comment is empty
  284 | ERROR   | Private method name "drupalchatController::_drupalchat_touch_user" is not in lowerCamel format
  294 | ERROR   | Doc comment is empty
  297 | ERROR   | Private method name "drupalchatController::_drupalchat_buddylist_diff" is not in lowerCamel format
  314 | ERROR   | Doc comment is empty
  317 | ERROR   | Public method name "drupalchatController::_drupalchat_buddylist" is not in lowerCamel format
  322 | ERROR   | The array declaration extends to column 172 (the limit is 80). The array content should be split up over multiple lines
  323 | WARNING | Unused variable $rid.
  328 | ERROR   | The array declaration extends to column 133 (the limit is 80). The array content should be split up over multiple lines
  337 | ERROR   | Doc comment is empty
  340 | ERROR   | Public method name "drupalchatController::_drupalchat_get_buddylist" is not in lowerCamel format
  352 | ERROR   | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
  353 | WARNING | Unused variable $rid.
  362 | ERROR   | The array declaration extends to column 133 (the limit is 80). The array content should be split up over multiple lines
  370 | ERROR   | Doc comment is empty
  373 | ERROR   | Public method name "drupalchatController::_drupalchat_buddylist_online" is not in lowerCamel format
  380 | ERROR   | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
  423 | ERROR   | The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
  429 | ERROR   | The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines
  446 | ERROR   | Public method name "drupalchatController::drupalchat_get_messages" is not in lowerCamel format
  465 | ERROR   | Comment indentation error, expected only 1 spaces
  468 | ERROR   | Comment indentation error, expected only 1 spaces
  477 | ERROR   | Doc comment is empty
  509 | WARNING | Line exceeds 80 characters; contains 124 characters
  548 | WARNING | Unused variable $record.
  550 | WARNING | Line exceeds 80 characters; contains 81 characters
  551 | WARNING | Line exceeds 80 characters; contains 421 characters
  562 | ERROR   | Doc comment is empty
  565 | ERROR   | Public method name "drupalchatController::drupalchat_get_messages_specific" is not in lowerCamel format
  576 | WARNING | Redeclaration of variable $user as global variable.
  616 | WARNING | Line exceeds 80 characters; contains 125 characters
  647 | ERROR   | Doc comment is empty
  650 | ERROR   | Public method name "drupalchatController::drupalchat_get_thread_history" is not in lowerCamel format
  653 | ERROR   | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('drupalchat_open_chat_uids') instead
  654 | ERROR   | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('drupalchat_open_chat_uids') instead
  668 | ERROR   | The array declaration extends to column 222 (the limit is 80). The array content should be split up over multiple lines
  671 | ERROR   | The array declaration extends to column 280 (the limit is 80). The array content should be split up over multiple lines
  679 | ERROR   | The array declaration extends to column 277 (the limit is 80). The array content should be split up over multiple lines
  689 | ERROR   | The array declaration extends to column 137 (the limit is 80). The array content should be split up over multiple lines
  690 | ERROR   | The array declaration extends to column 242 (the limit is 80). The array content should be split up over multiple lines
  701 | ERROR   | The array declaration extends to column 277 (the limit is 80). The array content should be split up over multiple lines
  712 | ERROR   | The array declaration extends to column 137 (the limit is 80). The array content should be split up over multiple lines
  713 | ERROR   | The array declaration extends to column 242 (the limit is 80). The array content should be split up over multiple lines
  729 | ERROR   | Doc comment is empty
  732 | ERROR   | Public method name "drupalchatController::drupalchat_return_pic_url" is not in lowerCamel format
  734 | WARNING | Unused variable $user.
  745 | ERROR   | Doc comment is empty
  748 | ERROR   | Public method name "drupalchatController::drupalchat_return_pic_url_any_user" is not in lowerCamel format
  751 | WARNING | Unused variable $user_picture.
  798 | ERROR   | Doc comment is empty
  801 | ERROR   | Public method name "drupalchatController::drupalchat_return_profile_url" is not in lowerCamel format
  810 | ERROR   | Doc comment is empty
  813 | ERROR   | Private method name "drupalchatController::_drupalchat_get_friends" is not in lowerCamel format
  824 | ERROR   | Private method name "drupalchatController::_drupalchat_get_groups" is not in lowerCamel format
  840 | ERROR   | Doc comment is empty
  843 | ERROR   | Public method name "drupalchatController::_drupalchat_get_user_details" is not in lowerCamel format
  869 | ERROR   | Comment indentation error, expected only 1 spaces
  872 | ERROR   | Comment indentation error, expected only 1 spaces
  876 | ERROR   | Comment indentation error, expected only 3 spaces
  892 | ERROR   | sizeof() is a function name alias, use count() instead
  975 | ERROR   | Doc comment is empty
  978 | ERROR   | Public method name "drupalchatController::_drupalchat_get_auth" is not in lowerCamel format
 1051 | ERROR   | Doc comment is empty
 1054 | ERROR   | Public method name "drupalchatController::ex_auth" is not in lowerCamel format
 1057 | WARNING | User::load calls should be avoided in classes, use dependency injection instead
 1057 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 1058 | WARNING | Unused variable $user_name.
 1069 | ERROR   | Public method name "drupalchatController::drupalchat_app_settings" is not in lowerCamel format
 1071 | WARNING | User::load calls should be avoided in classes, use dependency injection instead
 1071 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 1072 | WARNING | Unused variable $user_name.
 1089 | WARNING | Line exceeds 80 characters; contains 127 characters
 1089 | ERROR   | Comment indentation error, expected only 1 spaces
 1096 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 1103 | ERROR   | Doc comment is empty
 1106 | ERROR   | Public method name "drupalchatController::_drupalchat_chat" is not in lowerCamel format
 1122 | ERROR   | The array declaration extends to column 163 (the limit is 80). The array content should be split up over multiple lines
 1149 | WARNING | Line exceeds 80 characters; contains 96 characters
 1173 | ERROR   | Public method name "drupalchatController::_drupalchat_ur_autocomplete" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 823ms; Memory: 26MB
avpaderno’s picture

Issue summary: View changes
avpaderno’s picture

Status: Needs work » Needs review
arpitk’s picture

Assigned: Unassigned » arpitk
Status: Needs review » Needs work

Working on remaining issues as mentioned in #8.

arpitk’s picture

Assigned: arpitk » Unassigned
Status: Needs work » Needs review
arpitk’s picture

Title: Coding standards issues » Fix the issues reported by phpcs
avpaderno’s picture

Priority: Normal » Minor
Status: Needs review » Needs work

sourabhjain made their first commit to this issue’s fork.

sourabhjain’s picture

Status: Needs work » Needs review
avpaderno’s picture

Status: Needs review » Needs work
zkhan.aamir’s picture

Status: Needs work » Needs review
a.aaronjake’s picture

Status: Needs review » Needs work

Hi @everyone,

Applied the changes committed on MR!1, it was applied successfully but, the error below were still reported. Please see:

drupalchat git:(8.x-1.x) curl https://git.drupalcode.org/project/drupalchat/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  240k    0  240k    0     0   471k      0 --:--:-- --:--:-- --:--:--  483k
patching file config/install/drupalchat.settings.yml
patching file config/schema/drupalchat.schema.yml
patching file css/themes/dark/dark.css
patching file css/themes/light/light.css
patching file drupalchat.info.yml
patching file drupalchat.install
patching file drupalchat.libraries.yml
patching file drupalchat.links.menu.yml
patching file drupalchat.links.task.yml
patching file drupalchat.module
patching file drupalchat.routing.yml
patching file guest_names/drupalchat_guest_random_names.txt
patching file js/ba-emotify.js
patching file js/drupalchat-auth-token.js
patching file js/drupalchat-auth-url.js
patching file js/drupalchat-bundle.js
patching file js/drupalchat-jstorage.js
patching file js/drupalchat-path-visibility.js
patching file js/drupalchat-popup.js
patching file js/drupalchat-settings-options.js
patching file js/drupalchat.js
patching file src/Controller/drupalchatController.php
patching file src/Form/drupalchatSettingsForm.php
➜  drupalchat git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig drupalchat

FILE: ...o-site/drupal-orgissue-v9/web/modules/contrib/drupalchat/drupalchat.module
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 13 WARNINGS AFFECTING 17 LINES
--------------------------------------------------------------------------------
   8 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
   9 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  10 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  11 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  13 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  14 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  15 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  17 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  18 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  19 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  20 | WARNING | [ ] Global constants should not be used, move it to a class or
     |         |     interface
  44 | ERROR   | [x] Use statements should be sorted alphabetically. The first
     |         |     wrong one is
     |         |     Drupal\drupalchat\Controller\DrupalChatController.
  52 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
     |         |     "* Implements hook_foo_BAR_ID_bar() for block templates."
  97 | ERROR   | [ ] Doc comment is empty
 111 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 355 | ERROR   | [ ] Doc comment is empty
 410 | ERROR   | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...upal-orgissue-v9/web/modules/contrib/drupalchat/css/themes/light/light.css
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 245 | ERROR | Class definition is empty
 361 | ERROR | Class definition is empty
--------------------------------------------------------------------------------


FILE: ...-site/drupal-orgissue-v9/web/modules/contrib/drupalchat/drupalchat.install
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
  19 | WARNING | Line exceeds 80 characters; contains 93 characters
 113 | ERROR   | Doc comment is empty
 148 | ERROR   | Doc comment is empty
--------------------------------------------------------------------------------


FILE: ...site/drupal-orgissue-v9/web/modules/contrib/drupalchat/drupalchat.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml
   |         | file
--------------------------------------------------------------------------------


FILE: ...-orgissue-v9/web/modules/contrib/drupalchat/templates/drupalchat.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/drupalchat/templates/drupalchat-subpanel.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 25 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ssue-v9/web/modules/contrib/drupalchat/src/Form/drupalchatSettingsForm.php
--------------------------------------------------------------------------------
FOUND 11 ERRORS AND 7 WARNINGS AFFECTING 14 LINES
--------------------------------------------------------------------------------
   8 | ERROR   | [x] Use statements should be sorted alphabetically. The first
     |         |     wrong one is Drupal\Core\Url.
  17 | WARNING | [ ] The class short comment should describe what the class
     |         |     does and not simply repeat the class name
  18 | ERROR   | [ ] Class name must begin with a capital letter
  82 | ERROR   | [ ] The array declaration extends to column 351 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
  98 | WARNING | [ ] Line exceeds 80 characters; contains 150 characters
 103 | ERROR   | [ ] The array declaration extends to column 239 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 152 | WARNING | [ ] Translatable strings must not begin or end with white
     |         |     spaces, use placeholders with t() for variables
 152 | ERROR   | [ ] Concatenating translatable strings is not allowed, use
     |         |     placeholders instead and only one string literal
 152 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 198 | ERROR   | [ ] Inline doc block comments are not allowed; use "/* Comment
     |         |     */" or "// Comment" instead
 224 | ERROR   | [ ] The array declaration extends to column 309 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 304 | WARNING | [ ] Unused variable $user_name.
 384 | ERROR   | [ ] Doc comment is empty
 387 | WARNING | [ ] Unused private method _drupalchat_load_themes()
 387 | ERROR   | [ ] Private method name
     |         |     "drupalchatSettingsForm::_drupalchat_load_themes" is not
     |         |     in lowerCamel format
 405 | ERROR   | [ ] Doc comment is empty
 408 | WARNING | [ ] Unused private method _drupalchat_remove_extension()
 408 | ERROR   | [ ] Private method name
     |         |     "drupalchatSettingsForm::_drupalchat_remove_extension" is
     |         |     not in lowerCamel format
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/drupalchat/src/Controller/drupalchatController.php
--------------------------------------------------------------------------------
FOUND 92 ERRORS AND 15 WARNINGS AFFECTING 100 LINES
--------------------------------------------------------------------------------
    6 | ERROR   | [x] Use statements should be sorted alphabetically. The first
      |         |     wrong one is Drupal\Core\Controller\ControllerBase.
   24 | ERROR   | [ ] Class name doesn't match filename; expected "class
      |         |     drupalchatController"
   97 | ERROR   | [ ] Doc comment is empty
  100 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_verify_access" is not
      |         |     in lowerCamel format
  133 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
  154 | ERROR   | [ ] Doc comment is empty
  157 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_get_sid" is not in
      |         |     lowerCamel format
  179 | ERROR   | [ ] The $_COOKIE super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->cookies->get('drupalchat_c_session')
      |         |     instead
  196 | ERROR   | [ ] Doc comment is empty
  199 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_get_random_name" is not
      |         |     in lowerCamel format
  209 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_send" is not in
      |         |     lowerCamel format
  214 | ERROR   | [ ] The $_POST super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->request->get('form_token')
      |         |     instead
  215 | ERROR   | [ ] The $_POST super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->request->get('form_id')
      |         |     instead
  223 | ERROR   | [x] The first index in a multi-value array must be on a new
      |         |     line
  223 | ERROR   | [ ] The $_POST super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->request->get('drupalchat_message_id')
      |         |     instead
  223 | ERROR   | [x] Each index in a multi-line array must be on a new line
  224 | ERROR   | [x] Array indentation error, expected 8 spaces but found 6
  224 | ERROR   | [x] Each index in a multi-line array must be on a new line
  224 | ERROR   | [ ] The $_POST super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->request->get('drupalchat_uid2')
      |         |     instead
  224 | ERROR   | [x] Closing parenthesis of array declaration must be on a new
      |         |     line
  225 | ERROR   | [ ] The $_POST super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->request->get('drupalchat_message')
      |         |     instead
  238 | ERROR   | [ ] Doc comment short description must start with a capital
      |         |     letter
  239 | ERROR   | [ ] Doc comment short description must end with a full stop
  239 | ERROR   | [ ] Doc comment short description must be on a single line,
      |         |     further text should be a separate paragraph
  241 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_poll" is not in
      |         |     lowerCamel format
  251 | ERROR   | [ ] The $_GET super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->query->get('drupalchat_last_timestamp')
      |         |     instead
  252 | ERROR   | [ ] The $_GET super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->query->get('drupalchat_last_timestamp')
      |         |     instead
  280 | ERROR   | [ ] The array declaration extends to column 124 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  286 | ERROR   | [ ] The array declaration extends to column 141 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  295 | ERROR   | [ ] The array declaration extends to column 279 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  298 | ERROR   | [ ] The array declaration extends to column 318 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  307 | ERROR   | [ ] The array declaration extends to column 275 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  316 | ERROR   | [ ] The array declaration extends to column 135 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  317 | ERROR   | [ ] The array declaration extends to column 240 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  327 | ERROR   | [ ] The array declaration extends to column 275 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  336 | ERROR   | [ ] The array declaration extends to column 135 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  337 | ERROR   | [ ] The array declaration extends to column 240 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  361 | ERROR   | [ ] Doc comment is empty
  364 | ERROR   | [ ] Private method name
      |         |     "DrupalChatController::_drupalchat_touch_user" is not in
      |         |     lowerCamel format
  374 | ERROR   | [ ] Doc comment is empty
  377 | ERROR   | [ ] Private method name
      |         |     "DrupalChatController::_drupalchat_buddylist_diff" is not
      |         |     in lowerCamel format
  394 | ERROR   | [ ] Doc comment is empty
  397 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_buddylist" is not in
      |         |     lowerCamel format
  402 | ERROR   | [ ] The array declaration extends to column 172 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  403 | WARNING | [ ] Unused variable $rid.
  408 | ERROR   | [ ] The array declaration extends to column 133 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  417 | ERROR   | [ ] Doc comment is empty
  420 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_get_buddylist" is not
      |         |     in lowerCamel format
  433 | WARNING | [ ] Unused variable $rid.
  442 | ERROR   | [ ] The array declaration extends to column 133 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  450 | ERROR   | [ ] Doc comment is empty
  453 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_buddylist_online" is
      |         |     not in lowerCamel format
  526 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_get_messages" is not in
      |         |     lowerCamel format
  545 | ERROR   | [ ] Comment indentation error, expected only 1 spaces
  548 | ERROR   | [ ] Comment indentation error, expected only 1 spaces
  557 | ERROR   | [ ] Doc comment is empty
  589 | WARNING | [ ] Line exceeds 80 characters; contains 124 characters
  628 | WARNING | [ ] Unused variable $record.
  630 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  631 | WARNING | [ ] Line exceeds 80 characters; contains 421 characters
  642 | ERROR   | [ ] Doc comment is empty
  645 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_get_messages_specific"
      |         |     is not in lowerCamel format
  656 | WARNING | [ ] Redeclaration of variable $user as global variable.
  696 | WARNING | [ ] Line exceeds 80 characters; contains 125 characters
  727 | ERROR   | [ ] Doc comment is empty
  730 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_get_thread_history" is
      |         |     not in lowerCamel format
  733 | ERROR   | [ ] The $_POST super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->request->get('drupalchat_open_chat_uids')
      |         |     instead
  734 | ERROR   | [ ] The $_POST super global must not be accessed directly;
      |         |     inject the request_stack service and use
      |         |     $stack->getCurrentRequest()->request->get('drupalchat_open_chat_uids')
      |         |     instead
  748 | ERROR   | [ ] The array declaration extends to column 222 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  751 | ERROR   | [ ] The array declaration extends to column 280 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  759 | ERROR   | [ ] The array declaration extends to column 277 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  769 | ERROR   | [ ] The array declaration extends to column 137 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  770 | ERROR   | [ ] The array declaration extends to column 242 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  781 | ERROR   | [ ] The array declaration extends to column 277 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  792 | ERROR   | [ ] The array declaration extends to column 137 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  793 | ERROR   | [ ] The array declaration extends to column 242 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  809 | ERROR   | [ ] Doc comment is empty
  812 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_return_pic_url" is not
      |         |     in lowerCamel format
  814 | WARNING | [ ] Unused variable $user.
  825 | ERROR   | [ ] Doc comment is empty
  828 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_return_pic_url_any_user"
      |         |     is not in lowerCamel format
  831 | WARNING | [ ] Unused variable $user_picture.
  878 | ERROR   | [ ] Doc comment is empty
  881 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_return_profile_url" is
      |         |     not in lowerCamel format
  890 | ERROR   | [ ] Doc comment is empty
  893 | ERROR   | [ ] Private method name
      |         |     "DrupalChatController::_drupalchat_get_friends" is not in
      |         |     lowerCamel format
  904 | ERROR   | [ ] Private method name
      |         |     "DrupalChatController::_drupalchat_get_groups" is not in
      |         |     lowerCamel format
  920 | ERROR   | [ ] Doc comment is empty
  923 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_get_user_details" is
      |         |     not in lowerCamel format
  949 | ERROR   | [ ] Comment indentation error, expected only 1 spaces
  952 | ERROR   | [ ] Comment indentation error, expected only 1 spaces
  956 | ERROR   | [ ] Comment indentation error, expected only 3 spaces
  972 | ERROR   | [ ] sizeof() is a function name alias, use count() instead
 1055 | ERROR   | [ ] Doc comment is empty
 1058 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_get_auth" is not in
      |         |     lowerCamel format
 1131 | ERROR   | [ ] Doc comment is empty
 1134 | ERROR   | [ ] Public method name "DrupalChatController::ex_auth" is not
      |         |     in lowerCamel format
 1138 | WARNING | [ ] Unused variable $user_name.
 1149 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::drupalchat_app_settings" is not in
      |         |     lowerCamel format
 1152 | WARNING | [ ] Unused variable $user_name.
 1169 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
 1169 | ERROR   | [ ] Comment indentation error, expected only 1 spaces
 1183 | ERROR   | [ ] Doc comment is empty
 1186 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_chat" is not in
      |         |     lowerCamel format
 1202 | ERROR   | [ ] The array declaration extends to column 163 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
 1229 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
 1253 | ERROR   | [ ] Public method name
      |         |     "DrupalChatController::_drupalchat_ur_autocomplete" is
      |         |     not in lowerCamel format
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 1.21 secs; Memory: 20MB

Kindly check

Thanks,
Jake

avpaderno’s picture

GitLab CI still reports PHP_CodeSniffer errors/warnings.

Keep in mind that changing the name of public methods is not backward compatible. That needs to be done in a new branch, not in this branch.

avpaderno’s picture

Issue summary: View changes

avpaderno changed the visibility of the branch 3323914-gitlab-ci-reports to hidden.