GitLab CI reports PHP_CodeSniffer errors/warnings that should be fixed.
Issue fork drupalchat-3323914
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
avpadernoThe issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.
Comment #3
avpadernoComment #4
imustakim commentedComment #5
imustakim commentedIssue summary updated.
Comment #6
imustakim commentedComment #8
imustakim commentedSome of the issues are fixed in MR.
These are the remaining issue.
Comment #9
avpadernoComment #10
avpadernoComment #11
arpitk commentedWorking on remaining issues as mentioned in #8.
Comment #12
arpitk commentedComment #13
arpitk commentedComment #14
avpadernoComment #16
sourabhjainComment #17
avpadernoComment #18
zkhan.aamir commentedComment #19
a.aaronjake commentedHi @everyone,
Applied the changes committed on MR!1, it was applied successfully but, the error below were still reported. Please see:
Kindly check
Thanks,
Jake
Comment #21
avpadernoGitLab CI still reports PHP_CodeSniffer errors/warnings.
Keep in mind that changing the name of public methods is not backward compatible. That needs to be done in a new branch, not in this branch.
Comment #22
avpaderno