PostgreSQL driver doesn't support SSL option

Changing the name to reflect the real request here, and not duplicate #850592: Logon to PostgreSQL doesn't permit 'real' names....

PDO_pgsql doesn't support SSL, so there is nothing we can do about it here. Please open a feature request on php.net if you feel SSL support is important.

Altough the PDO driver does not support the SSL options for PostgreSQL, adding the options into the DSN works. I created a patch that makes possible to operate Drupal in an environment where PostgreSQL requires SSL and client certificates to work. The ideal solution would be if the DSN could be specified directly through settings.php, but that is a bigger effort.

With this patch, Drupal can be installed through Drush.

Adding tag and requested PG bot run.

Works with Drupal 9.3.4, PHP 8.1.4 and postgreSQL 13.5. It would be a nice feature; how is the review working on this one ?

Needs a reroll.

In 9.4.x core/lib/Drupal/Core/Database/Driver/pgsql/Connection.php became deprecated.

 @deprecated in drupal:9.4.0 and is removed from drupal:11.0.0. The PostgreSQL
 *   database driver has been moved to the pgsql module.

test bot issue

--- Commands Executed ---
core/scripts/dev/commit-code-check.sh --drupalci
Return Code: 1
--- Output ---
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:116:37 - Unknown word (sslmode)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:117:17 - Unknown word (sslmode)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:117:50 - Unknown word (sslmode)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:122:37 - Unknown word (sslkey)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:123:17 - Unknown word (sslkey)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:123:49 - Unknown word (sslkey)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:125:37 - Unknown word (sslrootcert)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:126:17 - Unknown word (sslrootcert)
/var/www/html/core/modules/pgsql/src/Driver/Database/pgsql/Connection.php:126:54 - Unknown word (sslrootcert)

CSpell: failed

Not sure what to do about this.

Drupal core runs cspell to spell check files in the project. We need to add words to its dictionary / ignore list.

"if there's an unrecognized English word or a correctly spelled technical term, add it to the Drupal dictionary file: core/misc/cspell/dictionary.txt (Note: all words in the dictionary must be lowercase)"

dictionary.txt is sorted alphabetically (a-z) so sslkey, sslmode, sslrootcert should follow after "ssid" in that file.

You fix those style guide violations by adding the following to the class file:

// cSpell:ignore sslmode sslkey sslrootcert

Insert it after the use-statements and before the class declaration.

Thanks for suggestions, trying the core misc cspell dictionary.txt

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Disregard comment #26, bug in the bot script

Seems like a feature that will need test coverage also.

Thanks.

I'm using this patch in a project where we just upgraded to core 10.1.6. The changes to dictionary.txt were not applying, so re-rolling patch to apply.

Just so our patches do not get forgotten:
The WxT distribution is still using this patch, between 200 and 300 installs, multiple public sector organizations, multiple installs in each organization.

@smulvih2 Shall I use the below patch in my Drupal 10.2.5 version?
https://www.drupal.org/files/issues/2023-11-14/postgresql-ssl-dns-850600...

Updating patch for 10.3.x. Looks like some items in dictionary.txt were removed since 10.1.x.