Comments

aspilicious’s picture

Status: Needs review » Needs work

It looks bad in IE7... :(

Jeff Burnz’s picture

Status: Needs work » Needs review
StatusFileSize
new3.26 KB

I had a crack at this and took a slightly different approach - moving where the borders/border radius are applied and padding etc.

Fixed the border radius stuff, chrome and opera were showing me the errors as they both support border-radius, Safari needed love also.

I think this looks better in IE7 and in general in other browsers also.

aspilicious’s picture

I'll test this now!

Jeff Burnz’s picture

Its not perfect... you will see, maybe you can ice the cake :)

aspilicious’s picture

StatusFileSize
new3.32 KB

I iced the cake :)!

Jeff Burnz’s picture

StatusFileSize
new3.5 KB

The patch in #5 doesnt look good in IE7, its jumping around on hover and still has the border issue.

That method is basically never going to work, the border will never trigger on the active class in IE7, so on the initial hover there is no border on div.contextual-links-active a.contextual-links-trigger, the border has to be on the anchor all the time, i.e. on a.contextual-links-trigger.

The problem I missed on my first attempt was the top: 19px; on div.contextual-links-wrapper ul.contextual-links - I went back to my original patch, removed the border-bottom on the trigger and changed the top value on ul.contextual-links to 18px and now, finally, its perfect.

I tested this in FF3, Opera10, Safari, Chrome, IE7/8 (all on Win). Needs testing in Mac browsers, should be good but you never know.

Status: Needs review » Needs work

The last submitted patch, contextual-rtl-css-fix_v4.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
StatusFileSize
new5.71 KB

Contextual links CAN'T have a backrgound when hovering. So it's not good. (screenshot)

The only thing that is wrong with my patch is the missing dotted border in IE7?

Jeff Burnz’s picture

Thats not the only problem in IE7, see the screenshots, its very bad in IE7 - the icon jumps around on hover, and border top on the UL shows over the trigger, the border on the trigger anchor doesnt show until you hover the UL links - 3 issues - do you have IE7 to test in?

When you see this hovering over something like the submit button for Search its actually preferable to have a background as you can barely see the icon, and what if the background is the exact same color as the icon - then its simply invisible. I can't see that having a background is "bad", in many cases it could be very good, by increasing the visibility of the trigger in low contrast conditions.

Jeff Burnz’s picture

StatusFileSize
new4.88 KB

Ops, forgot the screenshot (IE7), see how the borders are working - its hard for me to show the trigger icon moves as you hover back and fourth, its jumps and then locks in position.

My personal preference, is actually to have no background, and if we can make it work it would be good, but I dont think its bad to have a background, especially if it works and actually improves accessibility.

contextual-link-ie7.png

Jeff Burnz’s picture

StatusFileSize
new3.53 KB

OK, so heres the updated patch -this one has the transparent background on the icon, lets not creep the scope of the patch by introducing the background on the icon, thats another issue.

I got around the no-triggered-border thing in IE7 by declaring a transparent border on the anchor (sneaky eh?) which has tricked IE7 into working correctly, and I fixed the moving icon issue.

Not sure why that last patch failed, didnt do anything different than usual when rolling. See if the bot likes this one:

aspilicious’s picture

Lets try this.

My patch was working perfectly on my local ie8 with ie7 mode browser....

aspilicious’s picture

StatusFileSize
new12.53 KB

Everything looks fine except one bug in IE7.

Hovering the trigger of a node in the frontpage makes the post jump to the left.
==> Screenshot

Jeff Burnz’s picture

Probably a Garland issue in RTL, I tested with Stark and all is good, we'll need to try and nail down under what conditions this happens, I notice in Corolla its not even clickable in IE7 RTL.

Be good if we could get this committed sooner rather than later and not creep the scope and try a fix every issue in every core theme, otherwise these RTL improvements are going to drag on forever.

aspilicious’s picture

True I'll try another theme to and rtbc this if it's not present there.

aspilicious’s picture

Ok it's a garland bug :)

==> RTBC lets get these rtl patches in ;)

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.