Duplicate and incorrect error messages during install

Actually, the colours on the install are the proper one. The ones on the reports page shout, way to much. However, since we where in UI freeze - I am unsure if this is worth fixing.

I like it as it is...

Hm, I'm not totally convinced that #753754: Error message when settings file does not exist should be hidden solved the root cause of the duplicate error messages you were seeing, perhaps just the immediate symptom. Any other drupal_set_message() early enough in the installer will trigger it again.

The duplicate error messages are coming from http://api.drupal.org/api/function/theme_install_page/7. The code looks like this:

  // Special handling of error messages
  $messages = drupal_set_message();
  if (isset($messages['error'])) {
    $title = count($messages['error']) > 1 ? st('The following errors must be resolved before you can continue the installation process') : st('The following error must be resolved before you can continue the installation process');
    $variables['messages'] .= '<h3>' . $title . ':</h3>';
    $variables['messages'] .= theme('status_messages', array('display' => 'error'));
    $variables['content'] .= '<p>' . st('Check the error messages and <a href="!url">try again</a>.', array('!url' => check_url(request_uri()))) . '</p>';
  }

  // Special handling of warning messages
  if (isset($messages['warning'])) {
    $title = count($messages['warning']) > 1 ? st('The following installation warnings should be carefully reviewed') : st('The following installation warning should be carefully reviewed');
    $variables['messages'] .= '<h4>' . $title . ':</h4>';
    $variables['messages'] .= theme('status_messages', array('display' => 'warning'));
  }

  // Special handling of status messages
  if (isset($messages['status'])) {
    $title = count($messages['status']) > 1 ? st('The following installation warnings should be carefully reviewed, but in most cases may be safely ignored') : st('The following installation warning should be carefully reviewed, but in most cases may be safely ignored');
    $variables['messages'] .= '<h4>' . $title . ':</h4>';
    $variables['messages'] .= theme('status_messages', array('display' => 'status'));
  }

I'm really not sure most of that is serving any purpose anymore - is it? I think it might be left over from the days before Drupal had a nice status report in the installer, as it seems to be trying to do the same thing. I bet we can just delete most of that.

Per #8.

This was fixed as part of #807396: Remove old error handling from theme_update_page() - note that there were two commits in that issue (the first one is the one that directly fixed this). The above-referenced code was causing other bugs as well, so we simply deleted it and that was that :)

Sounds from #6 like the rest of the original issue here is being handled in #665790: Redesign the status report page, so marking this one as fixed.

I tryed to make an update of a module and I get I message saying there was some issues to resolve.
I couldnt resolve these issues. But drupal dont give me an iption to cancel de installation. It only says to resolve the issues and continue. If I try to open my website home screen it returns me a Server error!

I cannot install any version of any module because the drupal update.php crashed my website.

Any other url I try to open returns me a "Server Error" screen.

I can only open update.php and it only have a link to refresh the page.