After #653580: Upgrade to jQuery 1.4 was applied, I noticed that when you go to a page that doesn't have any menu items to manage (ex: /admin/structure/menu/manage/main-menu ) there is a error of :

$(".indentation", testCell).get(1) is undefined  -- Line 78 of tabledrag.js

This error occurs if the overlay module is on or not.

CommentFileSizeAuthor
#14 tabledrag_indentation_d6-737596-14.patch970 bytesgoron
#5 tabledragjquery14.patch1.06 KBcasey

Comments

aspilicious’s picture

aspilicious commented

Cannot reproduce with latest head.
Try to install again with latetst head, clear all caches and report back.

cosmicdreams’s picture

cosmicdreams commented

Hm...... well I'll give this a day. I deleted all of my major directories, refreshed from HEAD, flushed my browser and site cache. Saw the issue again in Firefox 3.5 and Chrome 5 (beta).

cosmicdreams’s picture

cosmicdreams commented

Hm......... "testcell". @aspilicious: do you have the Testing module enabled?

aspilicious’s picture

aspilicious commented

nop.... :)
So this is a real issue!

Nice find!

casey’s picture

casey commented
Status: Active » Needs review
StatusFileSize
new tabledragjquery14.patch1.06 KB

I can.

aspilicious’s picture

aspilicious commented

You removed a comment, can you write a new one?

casey’s picture

casey commented 
// Match immediate children of the parent element to allow nesting.

Patch doesn't do that any more; so that comment is obsolete.

aspilicious’s picture

aspilicious commented

You're right, and the comment above is telling what is happening.
Codewise this looks good but I need cosmicdreams or someone else to confirm that the message is gone.

cosmicdreams’s picture

cosmicdreams commented

I'm about to test this patch. Stay tuned.

cosmicdreams’s picture

cosmicdreams commented
Status: Needs review » Reviewed & tested by the community

Yep, that patch fixed the issues I was seeing in Firefox 3.5 and Chrome

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dkinzer’s picture

dkinzer commented

I was seeing this only when devel_themer was enabled.

goron’s picture

goron commented
Version: 7.x-dev » 6.x-dev
Priority: Critical » Normal
Status: Closed (fixed) » Patch (to be ported)
StatusFileSize
new tabledrag_indentation_d6-737596-14.patch970 bytes

This same problem is present in D6 as well. It's not as visible because as far as I can tell it doesn't happen anywhere out of the box, but it can come up if any module creates a draggable table that can be empty.

Here's a rerolled patch for D6. Pretty much exactly the same as the patch that got committed to D7 above.

goron’s picture

goron commented
Status: Patch (to be ported) » Needs review

actually this would be a better status

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.