Currently states.js just adds a "form-required" class to the dependee form element when marking it as required.
With this patch, I propose to improve this by matching the appearance of a plain Forms API required field, by adding a themable marker at the end of the corresponding label, identical by default to that defined by theme_form_required_marker.

CommentFileSizeAuthor
#6 match-states-api-required-736182-6.patch1.03 KBmanjit.singh
#2 states_and_or_xor_2.patch1.17 KBaspilicious
states_required_mark.patch1.23 KBpeterpoe

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work 
+++ misc/states.js	8 Mar 2010 16:43:31 -0000
@@ -352,7 +352,12 @@ states.State.prototype = {
+        $(e.target).closest('.form-item, .form-wrapper').find('label *:last').remove();

This should select .form-required

Powered by Dreditor.

aspilicious’s picture

aspilicious commented
StatusFileSize
new states_and_or_xor_2.patch1.17 KB

I tried this...

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work

This makes sense, please reroll against 8.x

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes
Issue tags: +Needs reroll
manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
StatusFileSize
new match-states-api-required-736182-6.patch1.03 KB

rerolling a patch :)

manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Status: Needs work » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: -Needs reroll
droplet’s picture

droplet commented
Version: 8.0.x-dev » 8.1.x-dev
Component: javascript » forms system
Issue tags: +JavaScript

Is it still an issue ? Steps to reproduce or a test module would help us to move it forward. Thanks.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: peterpoe » Unassigned
Status: Needs review » Needs work

I think this issue should be refocused to make FAPI match required state set by states.js

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andrewmacpherson’s picture

andrewmacpherson commented
Issue tags: +accessibility

Consistent and robust presentation of required form inputs is important for accessibility, see WCAG principle 3.3 Input Assistance.

#6 review:

  1. The patch predates the stable D8.0.0 release by several beta releases, so should be checked for consistency with the latest Drupal core behaviour. I'm not sure what changes during the D8.0.0 betas may relate to this.
  2. It needs to be updated for our use of *.es6.js files.
  3. +  Drupal.theme.prototype.formRequiredMarker = function () {
+    return '<span class="form-required" title="' + Drupal.t('This field is required.') + '">*</span>';
+  };

    I think this trying to provide a text alternative to the asterisk, for clarity in screen readers. This approach won't work.
    The title attribute is basically useless; the only users who will be able to perceive the title attribute on this asterisk span are sighted people, with a hover-capable pointer device, who are capable of pointer accuracy down to the level of individual characters.
    Static forms in D8 don't put an asterisk character into the HTML markup. Instead they use a visually hidden span of text, and the Classy theme adds an asterisk with CSS.

#12: I'm agnostic about which path we take to achieve consistency, so long as there are no regressions in the accessibility of non-dynamic forms currently.

andrewmacpherson’s picture

andrewmacpherson commented
Issue tags: -accessibility +Accessibility
andrewmacpherson’s picture

andrewmacpherson commented

test post, please ignore. Something odd is going on with tags, will file an issue with the drupal.org webmasters

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: -JavaScript +JavaScript, +wcag331

tagging
https://www.w3.org/WAI/WCAG21/Understanding/error-identification.html

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.