Add-remove-shortcut link issues

Patches like these need screenshots

Hm. I can't seem to find any visual difference at all, at least in Firefox. But I agree that screenshots showing the before/after picture in IE/Webkit would be nice. I'd also love for another person with some CSS chops to give this a once-over.

Are these simply CSS IE bugs?

Reroll - looks like one css rule was already in - so can somebody verify ?

+++ b/modules/shortcut/shortcut.cssundefined
@@ -51,13 +51,23 @@ div#toolbar div.toolbar-shortcuts span.icon {
+  ¶

trailing whitespace

+++ b/modules/shortcut/shortcut.cssundefined
@@ -95,6 +104,15 @@ div.add-or-remove-shortcuts a:hover span.text {
+/* IE6 needs this ruleset on this position. */
+div.add-or-remove-shortcuts a:hover {
+  width: auto;
+}
+div.add-or-remove-shortcuts a:hover span.text,
+div.add-or-remove-shortcuts a:focus span.text {
+  display: block;
+}

I'm 99,9999% sure we are NOT going to support IE6 in drupal 8. So I would leave this part out for D8.

25 days to next Drupal core point release.

@aspilicious Its not very drupalistic to not cater for that 00,00001% usecase :) But yhea, agreed.

2 patches then :)

@swentel you appended -D7, and -D8 that makes the bot ignore it.

Well, they're just css patches and they apply cleanly on my end, don't see any harm - someone just needs to test it locally to see if it's ok.

The hover is gone when the patch at #17 is applied. Checked on D8.

Here is the modified version of the patch for D8. On my environment, it solved the disappearing of the hover issue on Safari 5, Firefox 7, Chrome.

This is now probably redundant thanks to #1217038: Clean up the CSS for the Shortcut module, can anyone verify ?

Let's test to determine if this issue is still relevant in D8. If it is, the patch will need to be updated for D8. If not, we can close this issue as a duplicate.

Update- Tried to replicate issue using drupal 8 I did not see any visual difference in Firefox, IE or chrome as shown in attached screen shot. Closing this issue as duplicate of #1217030: Clean up the CSS for Overlay module

For reference, this is being closed as a duplicate of #1217038: Clean up the CSS for the Shortcut module, not #1217030: Clean up the CSS for Overlay module.

Re-opening temporarily so we can get some screenshots before closing again.

Screenshots of hover in D8.

Thanks @jesse.d! Re-closing as duplicate of #1217038: Clean up the CSS for the Shortcut module.

Removing Needs screenshots tag. Marked as duplicate. Duplicate marked Closed. Issue queue clean up for those searching for issues needing screenshots.