Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
user interface text
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
20 Nov 2009 at 01:45 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonAnd just a note that people are working on the hook_help() for tracker right now. If this issue is fixed, the help text will also need to reflect the new page name.
#635900: Help File Fixup: Tracker module
Comment #2
jhodgdonAdding tag
Comment #3
yoroy commentedPlease use tag 'usability' for general ux issues and keep d7ux tag for issues directly related to the D7UX proposals.
Re-componentalisation and a first stab at a fix!
Comment #5
yoroy commentedThere's also a path using 'posts'. I simply changed this to content. Fully expecting all kinds of breakage I probably don't know how to fix.
This patch does replace all occurances of 'post(s)' in tracker.module and should fix the previously failing test.
Comment #6
jhodgdonThere are still some uses of the term "post" in tracker.pages.inc that are not included in your patch.
I think the path change is probably OK, by the way. I don't see that being used/referenced anywhere else in the Drupal source. But it would potentially need to be documented on the Module Update Guide, in case some contrib module was referencing that exact path for some reason (not sure why they would, but you never know).
Comment #7
yoroy commentedYes, found two mentions there:
and a line in case there's no content available to show in the tracker
Where does one find the module update guide?
Comment #9
jhodgdonSomething you did there seems to have made the Tracker Test fail... Probably the test was looking for a particular piece of text and the text changed.
I also don't think we need to make this change in the watchdog log:
Comment #10
yoroy commentedAdressing both, hopefully.
Comment #11
lisarex commentedOK, applied the patch and it looks good to me (copy-wise, not sure about codey stuff)!
Related to this, the module page still describes Tracker as "Enables tracking of recent posts for users."
Comment #12
yoroy commentedgood catch.
Comment #15
agentrickardPatch applies fine. Cannot verify the syntax error report with php -l.
Requesting re-test.
Comment #16
lisarex commentedPatch applied and fixes issue in #11, all looks good to me!
Comment #17
webchickAwesome. Yay for consistency! Committed to HEAD.