Current UX guidelines for Drupal 7 suggest the use of "content" rather than the word "post".

The tracker module is still talking about "posts" in several screens. This should be changed.
- The tracker page is titled "Recent posts"
- Both the site-wide and user page display "no posts" when there aren't any yet

Comments

jhodgdon’s picture

And just a note that people are working on the hook_help() for tracker right now. If this issue is fixed, the help text will also need to reflect the new page name.
#635900: Help File Fixup: Tracker module

jhodgdon’s picture

Issue tags: +D7UX

Adding tag

yoroy’s picture

Component: tracker.module » user interface text
Status: Active » Needs review
Issue tags: -D7UX, -#d7ux +Usability
StatusFileSize
new2.99 KB

Please use tag 'usability' for general ux issues and keep d7ux tag for issues directly related to the D7UX proposals.

Re-componentalisation and a first stab at a fix!

Status: Needs review » Needs work

The last submitted patch failed testing.

yoroy’s picture

Status: Needs work » Needs review
StatusFileSize
new4.67 KB

There's also a path using 'posts'. I simply changed this to content. Fully expecting all kinds of breakage I probably don't know how to fix.

$items['user/%user/track/content'] = array(
    'title' => 'Track content',
    'type' => MENU_DEFAULT_LOCAL_TASK,
  );

This patch does replace all occurances of 'post(s)' in tracker.module and should fix the previously failing test.

jhodgdon’s picture

Status: Needs review » Needs work

There are still some uses of the term "post" in tracker.pages.inc that are not included in your patch.

I think the path change is probably OK, by the way. I don't see that being used/referenced anywhere else in the Drupal source. But it would potentially need to be documented on the Module Update Guide, in case some contrib module was referencing that exact path for some reason (not sure why they would, but you never know).

yoroy’s picture

Assigned: Unassigned » yoroy
Status: Needs work » Needs review
StatusFileSize
new5.63 KB

Yes, found two mentions there:

Only local images are allowed.

and a line in case there's no content available to show in the tracker

  else {
    $rows[] = array(array('data' => t('No content available.'), 'colspan' => '5'));
  }

Where does one find the module update guide?

Status: Needs review » Needs work

The last submitted patch failed testing.

jhodgdon’s picture

Something you did there seems to have made the Tracker Test fail... Probably the test was looking for a particular piece of text and the text changed.

I also don't think we need to make this change in the watchdog log:

-      watchdog('tracker', t('Indexed %count nodes for tracking.', array('%count' => $count)));
+      watchdog('tracker', t('Indexed %count pieces of content for tracking.', array('%count' => $count)));
yoroy’s picture

Status: Needs work » Needs review
StatusFileSize
new5.54 KB

Adressing both, hopefully.

lisarex’s picture

OK, applied the patch and it looks good to me (copy-wise, not sure about codey stuff)!

Related to this, the module page still describes Tracker as "Enables tracking of recent posts for users."

yoroy’s picture

StatusFileSize
new6.13 KB

good catch.

Status: Needs review » Needs work
Issue tags: -Usability

The last submitted patch failed testing.

Status: Needs work » Needs review
Issue tags: +Usability

agentrickard requested that failed test be re-tested.

agentrickard’s picture

Patch applies fine. Cannot verify the syntax error report with php -l.

Requesting re-test.

lisarex’s picture

Status: Needs review » Reviewed & tested by the community

Patch applied and fixes issue in #11, all looks good to me!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Awesome. Yay for consistency! Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.