Double arrows in next/prev links (book, forum)

You should put all adjacent t() calls into one. See the documentation for t() at http://drupaldocs.org/api/head/function/t.

Review:

• for usability if would be best that the double arrows are text (think screen-readers... double arrow is the start of a quote afaik, not a real arrow that is meant to point anywhere),
• however, it doesn't look nice to have for example: "next %title" as compared to "%title >>",
• book.module has the same links, so any patch should include those "arrows" too,
• the pager has two theming functions... maybe there should be a theme_next(), theme_prev() ? I can imagine people maybe wanting to make the "<<" a real image (with "<<" and/or next/prev as alt).

Rerolled the patch, including book.module, but without the "next" and "previous" words, just the arrows. But I do think that the title should be inside the t('%title >>', array('%title' => $next->title)) and not appended ($next->title . t(' >>')).

Patch works as expected so I'll mark it as RTBC, however the final version is just a minor readjustment of the current links. Also these are all theme_* functions so if you really want different links just override them in your theme. I'll leave it to the higher ups if they want to commit this or mark it as won't fix.

I have no opinion about this patch -- I guess it is an improvement, but I don't really understand how/why. Code looks good so feel free to commit.

why are we translating punctuation characters like t(' >>'))? this makes no sense to me. in fact, all of this: t('%title >>', array('%title' => $next->title)) seems like bloat that provides no useful localization functionality. i must be missing something... can someone enlighten me? are we worried about right-to-left languages or something?

thanks,
-derek

p.s. if you want to improve the usability of these links, far more useful (IMHO) is http://drupal.org/node/72467, which i'd love to see committed to 4.7.x, even. ;)

Translating » makes sense in case you got a language that actually points « to mean ». :)

This puts a literal <em>.

It's not a bug.

I think we are not going to change any UI text at the moment. Moving this to 8.x.

The issue referenced in #6 was committed #72467: Fix long links in forum/book navigation. Marking as a duplicate.