Problem/Motivation

#3569127: Add new 11.3.x database dump fixtures, without modules deprecated for removal in 12.x was the first part. Since then more modules have been deprecated, example telephone, so need to remove those.

One of the last steps for removing a module from core, is removing it from the update filled database dumps and any associated test coverage.

Batch the module removals so that we do multiple at once .

Steps to reproduce

Proposed resolution

Remaining tasks

The tricky thing will be determining timing of when we want to do this, and exactly which modules to do together.

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3607231

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Assigned: Unassigned » smustgrave

Giving this the college try

smustgrave opened merge request !16179

smustgrave’s picture

smustgrave commented

Uninstalled telephone, toolbar, and shortcut
Installed Navigation

I left search since it broke a bunch of tests since it's still so tightly tied to help, claro, and node.

There should be no errors in configuration ‘block.block.claro_help_search’. Errors:
Schema key block.block.claro_help_search:settings.page_id failed with: missing schema

Failed asserting that Array &0 [
    ‘block.block.claro_help_search:settings.page_id’ => ‘missing schema’,
] is true.
smustgrave’s picture

smustgrave commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented

I think we can open a separate issue for search, batching telephone, shortcut, toolbar + installing navigation is already going to cut down the number of times we need to update the database dumps by a lot.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Going on a limb and marking so we can unblock the removal :)

Opened #3607689: Remove search from 11.3.0.filled (if possible)

dcam’s picture

dcam commented

I diffed the previous fixture to the one in the MR.

I verified that the changes to core.extensions are correct per the list of changes in #4.

Unexpected changes:

  • Block UUIDs were updated.
  • Search configurations were updated.
  • block.block.stark_help was deleted.
  • block.block.stark_search was deleted.
  • Updates to search_page.entity_type

I could go on listing changes for a while. I didn't expect to see so many changes when diffing a dump that's less than three months old. I tried to see if the same thing happened when going from the 10.3 dump to 11.3. Unfortunately, that diff is ENORMOUS because it switched to the shorthand array syntax, resulting in thousands of changes. So it isn't great for comparison, but I looked through it enough to get a feeling that there weren't as many changes to data as this MR.

I don't entirely know what's happened here, but I have the feeling that the MR's dump brings a lot of things up-to-date with current code and configuration. One of the reasons for that assumption is the fact that I saw some entries that were previously versioned back to Drupal 9, now updated to 11.3. So that makes me wonder "Are all of these changes appropriate to this version of Drupal? Was the dump file just THAT out-of-date?" I don't know, but it's all I've got for now.

Assuming that most of the changes are fine and appropriate, the one thing that I saw over and over that gave me pause was changes related to the Search module. I wondered if there was an aborted attempt to remove the module that made its way into the dump. Some configurations related to Search were gone. Entire tables from Search were deleted. Probably this is fine since tests are passing and Search has to be removed soon anyway. But I'd like to hear @smustgrave's thoughts on this.

smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Needs review

Putting back in review.

I did attempt to uninstall search so wonder if that's the issue.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Ok, I think that's good to note. Again per my comment in #8, Search is still installed in the dump. It's just some of the data and configuration that has changed. I don't know if that would impact contrib modules or not or if this is something they'll have to adapt to soon anyway. Core's tests are still passing. I'm not going to argue with those results. We'll see what a committer thinks.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

If search was unsuccessfully uninstalled and re-installed that might explain things, I think we need a version with that having happened.

smustgrave’s picture

smustgrave commented

@catch that was the case so have to do it again?

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

ok redid it without trying search

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Alright, this time the diff was much cleaner. It looks good to me. Thanks for doing the extra work to regenerate it.

catch closed merge request !16179

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Not backporting this to 11.x because the modules are still in 11.x so we might theoretically still need upgrade paths to be written there (hopefully not though).

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed ab27842b on main 
    task: #3607231 Add new 11.3.x database dump fixtures, without modules...