Problem/Motivation

One of the last steps for removing a module from core, is removing it from the update filled database dumps and any associated test coverage.

Batch the module removals so that we do multiple at once .

Steps to reproduce

Proposed resolution

Remaining tasks

The tricky thing will be determining timing of when we want to do this, and exactly which modules to do together.

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3569127

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

catch’s picture

Status: Postponed » Active

I think we should look at doing this asap since people are already looking at module removals e.g. #3573484: Remove Contact module from core.

It ought to be something like:
1. Install 10.3 with the 10.3 filled database
2. Uninstall any modules listed on #3488826: [meta] Remove deprecated extensions from Drupal 12
3. Update to 11.3.x
4. Dump the database to a new 11.3 fixture.

mstrelan’s picture

It would be neat if there was a way to automate this in gitlab ci and upload an artifact. It could be a manually triggered job.

catch’s picture

andypost’s picture

smustgrave’s picture

quietone’s picture

quietone’s picture

Assigned: Unassigned » quietone

I'll take this on for a while.

catch’s picture

Status: Active » Needs review

This looks good to me. We should also backport to 11.x so that contrib modules can use it.

Once this is in, we'll be able to remove the old upgrade paths + testing + 10.3 database dumps.

quietone’s picture

Thanks. I'll review the steps I used to create this, hopefully tomorrow.

smustgrave’s picture

Could we merge these now and mark patch to be ported?

Also again shout out andypost for that workaround with uninstall-contact!

quietone’s picture

This will have to wait a week as catch is away and I haven't fully recovered from a flu.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

I'm only marking it if we could merge into main and mark to be backported. And I have bandwidth to help with #3580877: Remove updates added prior to 11.3.0 from 12.x if quietone needs it (hope you're feeling better from the flu!)

  • catch committed 81b82a68 on main
    task: #3569127 Add new 11.3.x database dump fixtures, without modules...

  • catch committed 06d89e94 on 11.x
    task: #3569127 Add new 11.3.x database dump fixtures, without modules...
catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

I also backported to 11.x by removing everything except the new database dump files from the diff, then committing the result.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

Assigned: quietone » Unassigned

Thanks catch. I was just getting back here to create the 11.x dump.

mondrake’s picture

Status: Fixed » Needs review

I think this has broken mysqli testing in HEAD, https://git.drupalcode.org/project/drupal/-/pipelines/792551

The mysqli module is missing when trying update tests.

catch’s picture

Status: Needs review » Needs work
quietone’s picture

It seems that the driver isn't being installed for UpdatePathTestBaseTest.php and UpdatePathTestBaseFilledTest.php. Not yet sure how to fix this.

Errors found
Database driver provided by module
Not installed
The current database driver is provided by the module: mysqli. The module is currently not installed. You should immediately install the module.
Checked

quietone’s picture

Status: Needs work » Needs review

Since mysqli is experimental, I added a new file to install mysql in the 11.3 dumps.

quietone’s picture

@godotislate, thanks! I completely forgot to update comments.

godotislate’s picture

Status: Needs review » Reviewed & tested by the community

Mysqli job ran and passed, so this lgtm.

  • catch committed 3d860a3c on 11.x
    task: #3569127 Add new 11.3.x database dump fixtures, without modules...

  • catch committed b32c2605 on main
    task: #3569127 Add new 11.3.x database dump fixtures, without modules...

  • catch committed d344795b on 11.x
    Revert "task: #3569127 Add new 11.3.x database dump fixtures, without...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks! I backported to 11.x then realised I shouldn't, so reverted that again.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.