When installing from an installation profile, the installer checks module requirements. If the public files directory is missing, it is created. When installing from a recipe, we get a warning instead:
Security warning: Couldn't write .htaccess file. Create a .htaccess file in your public:// directory which contains the following lines:
drupal_cms_helper module.drush site:export.sites/default/files.drush si ../recipes/site_export.Check module requirements when installing from recipe or config.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
darren ohI have provided a fix. I am not interested in writing tests or arguing about which files should hold the code.
Comment #4
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #5
kieran.cottinstall.incandinstall.core.incseem like reasonable choices, and the fix resolves the issue for me after reproducing the error locally.I've tweaked the logic a bit - config and recipe install modes should probably be checked before falling back to profile requirements, otherwise existing-config installs with a profile can still miss requirements from modules listed in
core.extension.yml.Also added some kernel test coverage and addressed the PHPCS/Stan failures.
Comment #6
kieran.cott