Problem/Motivation

It seems the value of msg is changed too late: https://git.drupalcode.org/project/drupal/-/blob/a50f2889df0000ac8793190...
This statement does basically nothing and is not needed (it converts msg to a string but messageTips needs to be an array).

Steps to reproduce

Proposed resolution

Remove it.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3586373-nr-bot_if4nesli.txt848 bytesneeds-review-queue-bot

Issue fork drupal-3586373

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff’s picture

prudloff commented
Issue tags: +Novice
ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel

ishani patel opened merge request !15541

ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review

Hello,
I've rasied MR.
Kindly review it.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3586373-nr-bot_if4nesli.txt848 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

alanampo made their first commit to this issue’s fork.

prudloff’s picture

prudloff commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me.