DDEV is the official local development tool of Drupal. And like Drupal, DDEV depends on the support of the open source community.Problem/Motivation
In views.api.php:
> function hook_views_query_alter(ViewExecutable $view, QueryPluginBase $query) {
The QueryPluginBase is not imported into the file with a use statement.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3528994-nr-bot.txt | 664 bytes | needs-review-queue-bot |
| #5 | After.png | 455.69 KB | divyat |
| #5 | Before.png | 445.94 KB | divyat |
Issue fork drupal-3528994
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3528994-docs-for-hookviewsqueryalter
changes, plain diff MR !12330
Comments
Comment #4
joachim CreditAttribution: joachim at Gulp Digital commentedPerfect, thanks!
(Remember to set issues to 'Needs review' when they're ready! :)
JS test failures are unrelated. RTBC.
Comment #5
divyat CreditAttribution: divyat at JBi Digital commentedI have replicated this locally & the provided solution works fine.
Here are the screenshots attached
Comment #6
joachim CreditAttribution: joachim at Gulp Digital commented@divyat There's no need to take screenshots of code being applied -- we can see the diff on gitlab and gitlab tells us that the MR can be merged cleanly.
Comment #7
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #8
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer commentedComment #9
sivaji_ganesh_jojodae CreditAttribution: sivaji_ganesh_jojodae as a volunteer and at Material for Material commentedComment #10
joachim CreditAttribution: joachim as a volunteer commentedI don't know what PHPStan is complaining about, but api.php files aren't executed, so it doesn't matter.
PHPCS is happy and that's what counts.
Comment #11
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #12
joachim CreditAttribution: joachim as a volunteer commentedComment #13
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer commentedComment #14
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer commentedSorry, in my browser data was not update to date when I tried to unassigned.
Updated to RTBC, again.
Comment #19
longwaveThanks for the fix. Backported down to 10.5.x as a docs-only bug fix.
Committed and pushed 13a1d338a4b to 11.x and 99ee2a84ebe to 11.2.x and 2039e4aaf6e to 10.6.x and 97cc774765c to 10.5.x. Thanks!