Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3528680

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

godotislate created an issue. See original summary.

godotislate opened merge request !12317

godotislate’s picture

godotislate
he/him
CreditAttribution: godotislate as a volunteer commented
Status: Active » Needs review

MR https://git.drupalcode.org/project/drupal/-/merge_requests/12317

godotislate’s picture

godotislate
he/him
CreditAttribution: godotislate as a volunteer commented

Split off updating Symfony to 7.3.0 from #3527142: Update Composer and development dependencies for 11.2.0 and 10.5.0, per #13:

Symfony 7.3.0 is also now out, and could be given its own issue as it's more critical than other updates.

godotislate’s picture

godotislate
he/him
CreditAttribution: godotislate as a volunteer commented

Removed the changes to composer/ca-bundle, composer/spdx-licenses (any non-Symfony packages).

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Zoocha, xjm, HeroDevs commented

Shouldn't there also be increases to the constraints in the core/composer.json in here?

godotislate’s picture

godotislate
he/him
CreditAttribution: godotislate as a volunteer commented
Issue tags: +Symfony 7.3, +11.2.0 release notes, +11.2.0 release target
godotislate’s picture

godotislate
he/him
CreditAttribution: godotislate as a volunteer commented

Added the version constraint changes to core/composer.json.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Zoocha commented
Status: Needs review » Needs work

NW for https://www.drupal.org/node/3522189 (I think) creeping in.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Zoocha commented
Status: Needs work » Needs review

Crosspost, you are fast like lightning!

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

We need separate MRs for both 11.x and 11.2.x as this has to land in both but the lockfile causes conflicts so we can't reuse the same patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

I actually think the core-recipe-unpack thing was correct.. it's in 11.2.x lockfile and should have been added to 11.x as well, otherwise I get this on install after switching branches:

Package operations: 0 installs, 3 updates, 1 removal
  - Removing drupal/core-recipe-unpack (11.2.x-dev)
  - Upgrading drupal/core-project-message (11.2.x-dev => 11.x-dev): Source already present
  - Upgrading drupal/core-vendor-hardening (11.2.x-dev => 11.x-dev): Source already present
  - Upgrading drupal/core (11.2.x-dev => 11.x-dev): Source already present
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Needs work

NW for #11/#12. Thanks @godotislate for helping out here!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Zoocha commented

I just confirmed that I get the recipe unpack stuff on a completely brand new repo as well. So it's either something that was failed to be added to the lock file in a previous issue, or a bug that was added in a previous issue... either way, out of scope here, and letting the lock file be what vanilla core generates out of the box is correct. Sorry @godotislate for the extra step!

godotislate opened merge request !12319

godotislate’s picture

godotislate
he/him
CreditAttribution: godotislate as a volunteer commented
Status: Needs work » Needs review

https://git.drupalcode.org/project/drupal/-/merge_requests/12317 11.x
https://git.drupalcode.org/project/drupal/-/merge_requests/12319 11.2.x

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

Let's stabilize it, recipe unpack hunk just skipped on git add -p meantime

  • xjm committed ebf960a1 on 11.x 
    Issue #3528680 by godotislate, xjm, longwave: Update to Symfony 7.3.0

  • xjm committed 4554754a on 11.2.x 
    Issue #3528680 by godotislate, xjm, longwave: Update to Symfony 7.3.0
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Zoocha, xjm commented
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and 11.2.x, thanks!

xjm closed merge request !12319

xjm closed merge request !12317

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Zoocha, xjm commented

 

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.