Problem/Motivation

If you visit the help page for the Navigation module there is text that says:

For more information, see the online documentation for the Navigation module.

The online documentation doesn't really exist, it just links to the contrib module page which doesn't have any additional documentation.

Steps to reproduce

Visit /admin/help/navigation

After

Proposed resolution

Remove the sentence.

Remaining tasks

Fixing it.

CommentFileSizeAuthor
#5 Navigation-help-text.png26.36 KBishani patel

Issue fork drupal-3524547

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

thejimbirch created an issue. See original summary.

thejimbirch’s picture

thejimbirch commented
Issue summary: View changes

Looks like it was removed in this big commit, but I don't see where it was replaced if so.

https://git.drupalcode.org/issue/drupal-3524547/-/commit/48c71f0598fe877...

ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel

ishani patel opened merge request !12129

ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review
StatusFileSize
new Navigation-help-text.png26.36 KB

Hello,
I've removed the sentence and created MR for that.
Kindly review.
Please refer the below screenshot for reference.

Navigation help text

Thank you!

chetansonawane’s picture

chetansonawane
he/him
Location Gujarat, India 🇮🇳
commented
Assigned: Unassigned » chetansonawane
chetansonawane’s picture

chetansonawane
he/him
Location Gujarat, India 🇮🇳
commented
Assigned: chetansonawane » Unassigned
Status: Needs review » Reviewed & tested by the community

I’ve reviewed the merge request, and removing the misleading sentence makes sense, especially since there isn’t any dedicated documentation available for the Navigation module beyond the contrib page.
This update helps avoid user confusion, and I believe it improves the overall clarity of the help text.

ishani patel’s picture

ishani patel commented
quietone’s picture

quietone commented
Issue summary: View changes

@chetansonawane, thanks for explaining what you did for the review.

I applied the diff and tested. While the help text is brief it is an improvement and the results match the provided 'after' screenshot. I added that to the issue summary. I updated credit.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Should this be linking to https://www.drupal.org/docs/develop/core-modules-and-themes/core-modules... instead - not that there is much there, but it seems like the right place to link to if there was more.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

That does seem more correct. Imagine once it’s more stable that documentation page will get some love

thejimbirch’s picture

thejimbirch commented
Status: Needs work » Needs review

Added the link back, and links to the recommended link.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Rock on, LGTM

  • catch committed 51b54bc2 on 11.2.x 
    Issue #3524547 by thejimbirch, ishani patel, quietone: Navigation module...

  • catch committed a2ec3114 on 11.x 
    Issue #3524547 by thejimbirch, ishani patel, quietone: Navigation module...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!

catch closed merge request !12129

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.