Problem/Motivation

Starting work on more words in tests. The only thing in common with these words is that they looked like straightforward fixes and they are only used in tests.

Steps to reproduce

Proposed resolution

  1. datetimeplus
  2. elems
  3. omittable
  4. pjpeg
  5. prophesized
  6. prophesizing
  7. reparenting
  8. ribisi
  9. tablesort's
  10. taskless
  11. testbots
  12. textboxes
  13. titlealert
  14. unrevisionable
  15. versionless
  16. xbap

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 3483542-nr-bot.txt90 bytesneeds-review-queue-bot

Issue fork drupal-3483542

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !9956

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review
quietone’s picture

quietone commented
Assigned: quietone » Unassigned
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Added missing word prophesized to summary

core/modules/system/tests/modules/jquery_key_event_polyfill_test/jquery_key_event_polyfill_test.libraries.yml was not sure if this would be out of scope adding it, but since it's a test don't see an issue.

Rest of the changes seem to make sense

quietone’s picture

quietone commented
Title: More words in tests » Fixes for spelling of 17 test related words
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3483542-nr-bot.txt90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review

linting checks have passed to setting this to review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Reviewed the changes and believe they read fine.

Believe the kernel test failure is valid though.

shalini_jha made their first commit to this issue’s fork.

shalini_jha’s picture

shalini_jha commented
Status: Needs work » Needs review

I have reviewed the pipeline and debugged the cause of the failure. Identified the issue and resolved it, resulting in the pipeline now passing successfully. Moving this to review.Kindly Review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

That seemed to be it.

  • larowlan committed 7fcbf3fd on 11.x 
    Issue #3483542 by quietone, shalini_jha: Fixes for spelling of 17 test...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed to 11.x - thanks!

larowlan closed merge request !9956

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.