Problem/Motivation

Follow up to #3353210-30: [PHPUnit 10] @dataProvider methods must be declared static and public.

Convert remaining Jsonapi module test dataproviders to static

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3439738

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !7395

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review

The testLinkMerge changes looked sensible so I replicated them in testLinkComparison.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community

Refactor seems fine, didn't break anything

  • catch committed 23519dbe on 10.3.x 
    Issue #3439738 by mondrake, longwave: Change remaining Jsonapi module...

  • catch committed 7ab4b0e7 on 11.x 
    Issue #3439738 by mondrake, longwave: Change remaining Jsonapi module...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

mondrake closed merge request !7395

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.