Follow-up for #3364109: opt in already validatable simple config to FullyValidatable

How will this affect overall core config validatability?

$ vendor/bin/drush pm:install config_inspector
$ vendor/bin/drush config:inspect --statistics > 3412084.json
$ curl https://project.pages.drupalcode.org/-/config_inspector/-/jobs/559249/artifacts/validatability-report/statistics/2024-01-02.json > HEAD.json
$ /usr/bin/diff --side-by-side HEAD.json 3412084.json | head -n 11
{									{
    "assessment": {							    "assessment": {
        "_description": "Default assessment generated fro		        "_description": "Default assessment generated fro
        "typesFullyValidatable": 0.005263157894736842,		|               "typesFullyValidatable": 0.01584507042253521,
        "typesInUse": 0.35789473684210527,			|               "typesInUse": 0.35563380281690143,
        "typesInUsePartiallyValidatable": 1,				        "typesInUsePartiallyValidatable": 1,
        "typesInUseFullyValidatable": 0.01470588235294117       |               "typesInUseFullyValidatable": 0.04455445544554455
        "typesInUsePropertyPathsFullyValidatable": 0.0059       |               "typesInUsePropertyPathsFullyValidatable": 0.0072
        "objectPropertyPathsValidatable": 0.5299947835159       |               "objectPropertyPathsValidatable": 0.5309928208720
        "objectPropertyPathsFullyValidatable": 0.00591201       |               "objectPropertyPathsFullyValidatable": 0.00726667
    },									    },

from 0.5% to 1.5% fully validatable types, and from 1.47% of in-use types being fully validatable to 4.45%.

IOW: this would make the brown and pink lines on https://project.pages.drupalcode.org/config_inspector/ go up quite noticeably 🤓

Very odd that it passed in the MR's test 🤔

Ah I see why … somehow this issue fork was created without #3364108: Configuration schema & required keys being present in the 11.x history of the fork 🤷‍♂️ And not enough time had passed for auto-retesting of RTBC against latest upstream.

So: merged in upstream 11.x, now this should fail too.

That failed as expected 👍

The fix is two-fold:

1. Trivial: PendingRevisionTest failed to install the default config of the Taxonomy module … and should have been doing that all along.
2. Simple: the taxonomy_settings migration: it was generating incomplete Drupal 8/9/10 config since the day it was introduced (#2154955: Migrate variables to config in 2014), because taxonomy.settings:maintain_index_table has existed since 2009 in Drupal 7 (see #412518: Convert taxonomy_node_* related code to use field API + upgrade path), its configuration schema was introduced in #1919208: Create configuration schemas for taxonomy module in 2013. But … it was not set by default: its absence was treated as taxonomy_maintain_index_table === TRUE.

It might be better to split off the taxonomy parts into a separate issue. Or, alternatively, to expand \Drupal\Core\Config\Schema\SchemaCheckTrait::$ignoredPropertyPaths rather than fixing the migration. Leaving that up to the reviewers to decide.

That was very fast 😅 Will do! Follow-up created already: #3413126: Add "maintain_index_table" to taxonomy_settings migration.

Addressed #17. 👍

#3413126: Add "maintain_index_table" to taxonomy_settings migration landed and hence this should be updated…

MR updated by deleting a handful of lines 👍 Back to RTBC!

… because I forgot to merge in upstream 🙈

git merge origin/11.x + push → green now 👍