Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
This is a child issue of #3376057: [META] Add declare(strict_types=1) to all tests.
Steps to reproduce
Add to phpcs.xml.dist:
<rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
<properties>
<property name="spacesCountAroundEqualsSign" value="0" />
</properties>
<include-pattern>./tests/Drupal/*.php</include-pattern>
<include-pattern>./tests/TestSuites/*</include-pattern>
<include-pattern>./modules/system/src/Tests/Routing/*</include-pattern>
<!-- Add exclude patterns here for paths covered by other in progress issues -->
</rule>
Run phpcs:
composer phpcs
Proposed resolution
Run phpcbf:
composer phpcbf
Remaining tasks
Review changes in these files (MR !6004):
- core/modules/field/tests/src/Functional/NestedFormTest.php
- core/tests/Drupal/TestTools/Random.php
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | 3407793-nr-bot.txt | 15.69 KB | needs-review-queue-bot |
Issue fork drupal-3407793
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
mstrelan commentedComment #4
mstrelan commentedPostponed on fixing the fails which will happen in another issue that's yet to be created
Comment #7
mstrelan commentedSince there are only two small fixes maybe we can do this all in a single issue. The two files with fixes to review are:
Comment #8
smustgrave commentedHave not reviewed
Seems to have a number of test failures spread out.
Comment #9
mstrelan commentedSee #7, I think we can fix errors and apply the statement in the one issue here since the fixes are literally only two words. So MR 6004 is the green one and the files with the fixes are listed in the IS.
Comment #11
smustgrave commentedOh that MR looks fine to me then.
Comment #12
quietone commentedI left a question
Comment #13
mstrelan commentedQuestion answered, not sure if I can set back to RTBC so leaving NR.
Comment #14
smustgrave commentedRestoring status as question is answered.
Comment #16
larowlanCommitted to 11.x
Moving to 10.2.x for backport
Comment #18
mstrelan commentedBackported to 10.2.x minus the change to phpcs.xml.dist
Comment #19
smustgrave commentedReroll for 10.2 seems good.
Comment #20
mstrelan commentedNightwatch seems to be failing and I don't know how to interpret the output.
Comment #21
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #22
mstrelan commentedRebased and nightwatch passing now. Back to RTBC as per #19.
Comment #23
longwaveCommitted d7e0df2 and pushed to 10.2.x. Thanks!