Problem/Motivation

When configuring the filters for a text format the "Align Image" and "Caption Image" filters say they are for IMG tags, their descriptions do not indicate they also work with media items.

Proposed resolution

Update the descriptions of the "Align image" and "Caption image" filters to indicate they work with embedded media, not just IMG tags.

Remaining tasks

Do the thing.

User interface changes

The descriptions of the Align Image and Caption Image filters indicate they work on media items too.

API changes

n/a

Data model changes

n/a

Release notes snippet

TBD

CommentFileSizeAuthor
#2 drupal-n3390601-2.patch1.47 KBdamienmckenna

Issue fork drupal-3390601

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new1.47 KB

This patch changes the descriptions on those two filters.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Since this is just a description don't think it will need a test case, and agree the change seems fine to me.

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

sivaji_ganesh_jojodae made their first commit to this issue’s fork.

sivaji_ganesh_jojodae’s picture

Status: Needs work » Needs review

In the MR I've updated the description to include media usage as well.

smustgrave’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative, +Novice

Seems like a small enough change. Probably should of been tagged novice for new users but it's fine since it wasn't before.

Thanks

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

The tips for align say return $this->t('You can align images (<code>data-align="center"), but also videos, blockquotes, and so on.');
And for caption say $this->t('You can caption images (<code>data-caption="Text"), but also videos, blockquotes, and so on.');

So I think we should have another think about what this text should be because it works on more than just embedded media.