Problem/Motivation
When configuring the filters for a text format the "Align Image" and "Caption Image" filters say they are for IMG tags, their descriptions do not indicate they also work with media items.
Proposed resolution
Update the descriptions of the "Align image" and "Caption image" filters to indicate they work with embedded media, not just IMG tags.
Remaining tasks
Do the thing.
User interface changes
The descriptions of the Align Image and Caption Image filters indicate they work on media items too.
API changes
n/a
Data model changes
n/a
Release notes snippet
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | drupal-n3390601-2.patch | 1.47 KB | damienmckenna |
Issue fork drupal-3390601
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
damienmckennaThis patch changes the descriptions on those two filters.
Comment #3
smustgrave commentedSince this is just a description don't think it will need a test case, and agree the change seems fine to me.
Comment #4
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
Comment #8
sivaji_ganesh_jojodae commentedIn the MR I've updated the description to include media usage as well.
Comment #9
smustgrave commentedSeems like a small enough change. Probably should of been tagged novice for new users but it's fine since it wasn't before.
Thanks
Comment #10
alexpottThe tips for align say
return $this->t('You can align images (<code>data-align="center"), but also videos, blockquotes, and so on.');And for caption say
$this->t('You can caption images (<code>data-caption="Text"), but also videos, blockquotes, and so on.');So I think we should have another think about what this text should be because it works on more than just embedded media.