Problem/Motivation
When in the Fields -> Rearrange dialog window of the Views backend, the "Remove" links do not align properly with the column header.
Steps to reproduce
- Install the latest version of Drupal
- (If #3375806: Views 'Rearrange' dialog show the 'Remove' checkbox, which should be visually hidden is not yet committed, apply patch #15.)
- Go to Structure -> Views -> "Comments" (for example)
- Click the dropdown icon next to Fields - Add and click Rearrange
- You will see that the "Remove" links behind every field do not line up properly to the column header ("Remove")

Proposed resolution
Add a few lines to core/themes/claro/css/components/views-ui.css:
html.js .views-ui-dialog .draggable .form-type--checkbox {
display: none;
}
Remaining tasks
Write a patch- Review, test
- Wait for #3375806: Views 'Rearrange' dialog show the 'Remove' checkbox, which should be visually hidden to be committed
- Commit
User interface changes
Improved alignment of "Remove" links in the Views UI dialog.
| Comment | File | Size | Author |
|---|
Issue fork drupal-3376159
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3376159-link-align-d11
changes, plain diff MR !6127
- 3376159-links-do-not
compare
Comments
Comment #2
tintoHere's a patch that adds a few lines to
core/themes/claro/css/components/views-ui.css.Comment #3
tintoComment #4
tintoOops, forgot to include the changes in the accompanying .pcss.
Comment #5
tintoComment #6
smustgrave commentedConfirmed the issue in the IS.
Changed to a minor though.
Applied patch #5 and it did fix it.
Comment #8
smustgrave commentedBelieve to be random. Restarted tests
Comment #9
lauriiiIdeally we could use '#wrapper_attributes' but we can't because it's also picked up by the table column 😬 Maybe something like this could work?
Comment #10
smustgrave commentedTested patch #9 and verified on the content view links are still aligned with the Remove table header.
Comment #11
quietone commentedI'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions or other work to do.
Leaving at RTBC.
Comment #13
smustgrave commentedSeems unrelated
Comment #15
Harish1688 commentedHi,
As per ticket status (Needs Work) looks the issue, but found it's resolved by the #9 patch. resolved the Remove links alignment issue.
After patch:

Comment #17
aditi saraf commentedHi , I have fixed the issue . Please review .
Comment #19
smustgrave commented@Aditi Saraf there is no interdiff or explanation for why the solution has changed. #9 still applies and was moved to NW by a random failure. Hiding #17 and restoring RtBC status
Comment #20
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
Comment #21
djsagar commentedHi all,
I applied and tested patch #9 in drupal 11, Issue is resolved.
Patch # 17 is not required.
Testing steps:
Before

After

Moving this to RTBC
Thakns!
Comment #22
longwaveDrupalCI is broken, and the tests on #9 are failing. Can someone convert #9 to an MR and hide the patches? It can be immediately marked RTBC if the tests pass.
Comment #25
smustgrave commentedHiding patches and dangling branch
Comment #26
longwaveCommitted and pushed 59f0e738c0 to 11.x and 2774aab1e0 to 10.2.x. Thanks!