Problem/Motivation

When in the Fields -> Rearrange dialog window of the Views backend, the "Remove" links do not align properly with the column header.

Steps to reproduce

  1. Install the latest version of Drupal
  2. (If #3375806: Views 'Rearrange' dialog show the 'Remove' checkbox, which should be visually hidden is not yet committed, apply patch #15.)
  3. Go to Structure -> Views -> "Comments" (for example)
  4. Click the dropdown icon next to Fields - Add and click Rearrange
  5. You will see that the "Remove" links behind every field do not line up properly to the column header ("Remove")

Remove links no longer align properly with the table column header label

Proposed resolution

Add a few lines to core/themes/claro/css/components/views-ui.css:

html.js .views-ui-dialog .draggable .form-type--checkbox {
  display: none;
}

Remaining tasks

User interface changes

Improved alignment of "Remove" links in the Views UI dialog.

Issue fork drupal-3376159

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tinto created an issue. See original summary.

tinto’s picture

StatusFileSize
new720 bytes

Here's a patch that adds a few lines to core/themes/claro/css/components/views-ui.css.

tinto’s picture

Issue summary: View changes
tinto’s picture

Status: Postponed » Needs review
StatusFileSize
new612 bytes

Oops, forgot to include the changes in the accompanying .pcss.

tinto’s picture

StatusFileSize
new1.42 KB
smustgrave’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Confirmed the issue in the IS.
Changed to a minor though.
Applied patch #5 and it did fix it.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 3376159-4.patch, failed testing. View results

smustgrave’s picture

Status: Needs work » Reviewed & tested by the community

Believe to be random. Restarted tests

lauriii’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.59 KB

Ideally we could use '#wrapper_attributes' but we can't because it's also picked up by the table column 😬 Maybe something like this could work?

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Tested patch #9 and verified on the content view links are still aligned with the Remove table header.

quietone’s picture

I'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions or other work to do.

Leaving at RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 3376159-9.patch, failed testing. View results

smustgrave’s picture

Status: Needs work » Reviewed & tested by the community

Seems unrelated

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 3376159-9.patch, failed testing. View results

Harish1688’s picture

StatusFileSize
new49.35 KB

Hi,

As per ticket status (Needs Work) looks the issue, but found it's resolved by the #9 patch. resolved the Remove links alignment issue.

After patch:
issue image

Aditi Saraf made their first commit to this issue’s fork.

aditi saraf’s picture

Status: Needs work » Needs review
StatusFileSize
new624 bytes
new56.98 KB

Hi , I have fixed the issue . Please review .

Status: Needs review » Needs work

The last submitted patch, 17: 3376159-17.patch, failed testing. View results

smustgrave’s picture

Status: Needs work » Reviewed & tested by the community

@Aditi Saraf there is no interdiff or explanation for why the solution has changed. #9 still applies and was moved to NW by a random failure. Hiding #17 and restoring RtBC status

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

djsagar’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new1.05 MB
new1.02 MB

Hi all,

I applied and tested patch #9 in drupal 11, Issue is resolved.
Patch # 17 is not required.

Testing steps:

  1. Install the latest version of Drupal
  2. Go to Structure -> Views -> "Comments" (for example)
  3. Click the dropdown icon next to Fields - Add and click Rearrange

Before
issue

After
fixed

Moving this to RTBC

Thakns!

longwave’s picture

Status: Reviewed & tested by the community » Needs work

DrupalCI is broken, and the tests on #9 are failing. Can someone convert #9 to an MR and hide the patches? It can be immediately marked RTBC if the tests pass.

smustgrave changed the visibility of the branch 3376159-links-do-not to hidden.

smustgrave’s picture

Status: Needs work » Reviewed & tested by the community

Hiding patches and dangling branch

longwave’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 59f0e738c0 to 11.x and 2774aab1e0 to 10.2.x. Thanks!

  • longwave committed 2774aab1 on 10.2.x
    Issue #3376159 by tinto, smustgrave, lauriii, djsagar, Harish1688: Links...

  • longwave committed 59f0e738 on 11.x
    Issue #3376159 by tinto, smustgrave, lauriii, djsagar, Harish1688: Links...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.