Problem/Motivation
The taxonomy translation migrations do not depend on the migrations that set the language content settings for taxonomy.
This was discovered while testing #3015369: Fix MigrateTestBase::executeMigrations() to execute migrations in dependency order.
Steps to reproduce
Proposed resolution
Modify d7_language_content_taxonomy_vocabulary_settings to run after d7_entity_translation_settings and skip the row if the language settings were created by d7_entity_translation_settings
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3371869
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3371869-fix-dependencies-of
changes, plain diff MR !5488
Comments
Comment #2
quietone commentedThe first step was to add a skip_on_empty if the content language settings existed.
Comment #4
quietone commentedSo, that proves that the new pipeline works.
Then add an optional dependency on
d7_entity_translation_settingsd7_language_content_taxonomy_vocabulary_settings.ymlso that it runs first. And then add a dependency ond7_language_content_taxonomy_vocabulary_settingsto the taxonomy term translation migrations.The changes to drupalci and the test are not needed, that leaves a patch with changes to 4 migrations.
Edit: s/to a 4/to 4/
Comment #5
smustgrave commentedThink the fail patch does a good job showing the problem.
So the change looks good to me.
Comment #6
quietone commentedI triaged this RTBC issue sometime in the last weeks but didn't leave a comment.
I didn't find anything that needed to be done.
Leaving at RTBC
Comment #8
smustgrave commentedRerunning tests but believe to be unrelated.
Comment #10
smustgrave commentedRerunning believe to be unrelated
Comment #11
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
Comment #12
smustgrave commentedThink this one was simple enough and clear which patch to use. Going to remark it.
Comment #14
quietone commentedThe patch in #4 was failing and I tracked it to #3015369: Fix MigrateTestBase::executeMigrations() to execute migrations in dependency order. That issue ensures that the migrations will be ordered by dependency before execution. This resulted in the following error.
This is happening because 'language_content_settings' was being run last in that group. It needs to be before any translation migration and other 'language_content_settings' ones. The change was to add a dependency to d7_language_content_taxonomy_vocabulary_settings.yml so that it runs after d7_language_content_settings, if it exists.
Comment #15
smustgrave commentedRandom nightwatch failure
Comment #16
catchCommitted/pushed to 11.x and cherry-picked to 10.2.x, thanks!