Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
On Desktop view mode when we add too many menu items link, the main navigation switch into burger menu for desktop and search block comes inside it. Need to make search block out from the burger menu panel.
Steps to reproduce
1. Setup Drupal and add menu items into the main navigation. admin/structure/menu/manage/main
2. Horizontal menu will be switch into burger menu panel. search block will be show inside the panel.
Proposed resolution
Keep the search block outside the menu panel.
User interface changes
Issue:
Solution:
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | Screenshot at Oct 17 16-47-26.png | 1.6 MB | shweta__sharma |
| #24 | Screenshot at Oct 17 16-42-02.png | 175.11 KB | shweta__sharma |
| #24 | Screenshot at Oct 17 16-28-17.png | 213.6 KB | shweta__sharma |
| #23 | 3370683 search ouside 2.png | 9.35 KB | Harish1688 |
| #23 | 3370683 search ouside.png | 29.68 KB | Harish1688 |
Issue fork drupal-3370683
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
hamid.ali commentedWorking on this will provide the patch to the following issue.
Comment #3
hamid.ali commentedAttaching the patch
Comment #4
hamid.ali commentedWorking on the tests
Comment #5
hamid.ali commentedAdding Updated patch
Comment #6
hamid.ali commentedWork in progress
Comment #7
catchComment #8
gauravvvv commentedI have fixed the build errors, also added the interdiff for same. please review
Comment #9
hamid.ali commentedSince custom commands are failing I am working on the fix will provide the updated patch
Comment #10
hamid.ali commentedAdding the patch and the interdiff file.
Comment #11
hamid.ali commentedLatest patch with the interdiff file.
Comment #12
hamid.ali commentedKindly review the issue
Comment #13
smustgrave commented@Hamid.ali please don't assign tickets to yourself unless a maintainer per the policy.
Tagging for subsystem maintainer to see if this is actually a bug.
Comment #16
smustgrave commentedRemoving credit for @arti_parmar for the empty MR.
Comment #17
volkswagenchick@arti_parmar FULL TRANSPARENCY: I have already commented on another issue about this same behavior..
I see you have opened a merge request that is empty. Perhaps you do not know the process?
Here is a link to some documentation on Drupal.org: Creating merge requests
When you open a merge request or post a file it ticks the credit box for attribution and creates more work for maintainers when they close the issues. Please refrain from opening a merge request unless you are working on code.
@smustgrave has already unticked the attribution box, as you did not contribute to the conversation, let me know if you have any questions.
~AmyJune, Core Mentor and CWG Community Health team member
Comment #18
volkswagenchick@Hamid.ali Here is a link to issue queue etiquette:
Issue Queue Etiquette
# 9 in the Donts section
Don't: Assign yourself issues in the Drupal Core issue queue. That is saved for maintainers of the project. Please note, you can use a comment to inform others that you are working on an issue.~AmyJune, Core Mentor and CWG Community Health team member
Comment #19
lokeshsahu commentedI tried to reproduce and fix the above-addressed issue with the help of patch #11 on Drupal-10.1.x-dev. The patch was applied successfully without throwing any error and fixed the raised issue. The updated changes match the figma design as well. I am attaching a screenshot for reference, showing the state before and after applying the patch.
Comment #20
snehal-chibde commentedHello, applied patch #3 and it is working a expected. Here are the before and after screenshots for desktop and mobile. RTBC++.
Comment #21
shweta__sharma commentedMoving this to RTBC based on #19 and #20.
Thanks
Comment #22
quietone commentedI'm triaging RTBC issues.
This issue does not have an issue summary! There is no explanation of the problem or what the fix is supposed to do. The title is often a clue but in the case it does not help me know what the problem is. The issue summary should contain the important information that committers and reviewers need to assess a change. Since that is missing, I am setting to 'Needs work' for an issue summary update and tagging. I am also restoring the standard template that should be used for all core issues. It is how we keep track of the work completed and the work still to do.
There is lots of information in the Drupal wiki that explains how we work. In particular, there is information for how to Write an issue summary for an existing issue. There is also more information at Issue summaries matter.
@snehal-chibde, testing of a patch should be done on the latest version. If not, then you should explain why testing was done on an old version.
This issue has patches and an MR. It will help if the issue summary clarifies which one is the reviewed.
Comment #23
Harish1688 commentedBased on the comment #22, added the issue summary.
Also Tested the patch 3370683-11.patch with latest 11.x. But found a issue in that, after applying the patch search icon not showing. attached a image for reference.
Testing with version 11.x
Comment #24
shweta__sharma commentedHi @Harish1688,
It is visible for screens above 1024px and for the below screens it follows the mobile design in which the search block is placed inside the hamburger panel.
Tested #11 patch with Drupal 11.x working fine the search block is designed as per the requirement mentioned in the IS but still, some issues exist -
- Focus ring is misaligned on the search icon.
- Alignment of the search icon and the menu does not look correct below 1200px screen.