Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Apr 2023 at 16:02 UTC
Updated:
14 Aug 2025 at 20:54 UTC
Jump to comment: Most recent
Problem/Motivation
During the D10 lifecycle, some method in interfaces were preliminarily added or typehinted by adding inline comments in place of the to-be real parameters. This allows Symfony's debug classloader to report deprecations for methods that do not implement the stealth parameters, i.e. the concrete classes will throw implementation errors even if the interfaces are not yet formally enforcing the signatures.
The following interfaces need to be adjusted prior to 11.0.0:
- Drupal\Core\Database\StatementInterface: fixed in #3256524: [11.x] Adjust Database API to remove deprecated Drupal 10 code in Drupal 11
- Drupal\Core\Form\FormBuilderInterface: fixed in #3431285: Replace func_get_args with variable-length argument in FormBuilder
- Drupal\Core\Session\AccountInterface: #3415189: Tighten typehint in UserSession::hasPermission() and User::hasPermission()
Comments
Comment #2
gábor hojtsyUpdating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...
Comment #3
quietone commentedAdd parent for D11.
Comment #4
mondrakeComment #5
mondrakeThis meta can be probably closed now?
Comment #6
smustgrave commentedDoes seems like all issues mentioned have been closed. Not sure I can close a META
Comment #7
longwaveWhat about
AccountInterface::hasPermission()?#3415189: Tighten typehint in UserSession::hasPermission() and User::hasPermission()
I found this by searching for
function.*\*, this is the only remaining instance.Comment #8
mondrakeYes.
Comment #9
quietone commentedComment #10
andypostComment #11
smustgrave commentedCan I make the recommendation this meta be used for 12 release and then closed?
Comment #12
mondrakeI agree with #11, made IS changes so this is no longer a meta and once completed, we can close it.
Comment #13
quietone commentedI was just commenting that I disagree with #11. That is, that an issue for D11 work should stay with a D11 parent and so forth. It does help when creating all the issues needed for a new major version.
And while this was being created I created a new issue for Drupal 12. #3522129: [META] Adjust parameters in interfaces. So, there is some issue management to do which I can do in a bit.
Comment #14
quietone commentedComment #15
quietone commentedFixes were made in child issues and I haven't found any more. So, I think this is fixed.
Comment #16
smustgrave commentedThere are none merged tickets attached still. Should those all be kicked back?
Comment #17
xjmRTBC doesn't really make sense as a status here; there's nothing for a committer uninvolved with the issue to do.
@smustgrave, is your question about related issues? Related issues can be open when a meta is closed; that's fine. It's only when it's child issues that we need to reparent them to somewhere else.
So I'd suggest marking this directly to fixed if that addresses your question. Thanks!
Comment #18
smustgrave commentedGoing on a limb but this seems like the correct status now..