Problem/Motivation

During the D10 lifecycle, some method in interfaces were preliminarily added or typehinted by adding inline comments in place of the to-be real parameters. This allows Symfony's debug classloader to report deprecations for methods that do not implement the stealth parameters, i.e. the concrete classes will throw implementation errors even if the interfaces are not yet formally enforcing the signatures.

The following interfaces need to be adjusted prior to 11.0.0:

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

mondrake created an issue. See original summary.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: [D11] Adjust parameters in interfaces » [11.x] Adjust parameters in interfaces
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Title: [11.x] Adjust parameters in interfaces » Adjust parameters in interfaces
Parent issue: » #3402452: [meta] Requirements for tagging 11.0.0-alpha1

Add parent for D11.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Active » Needs review

This meta can be probably closed now?

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Title: Adjust parameters in interfaces » [META] Adjust parameters in interfaces
Status: Needs review » Reviewed & tested by the community

Does seems like all issues mentioned have been closed. Not sure I can close a META

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Reviewed & tested by the community » Needs review

What about AccountInterface::hasPermission()?

#3415189: Tighten typehint in UserSession::hasPermission() and User::hasPermission()

I found this by searching for function.*\*, this is the only remaining instance.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue summary: View changes
Status: Needs review » Active
Related issues: +#3256524: [11.x] Adjust Database API to remove deprecated Drupal 10 code in Drupal 11, +#3431285: Replace func_get_args with variable-length argument in FormBuilder, +#3415189: Tighten typehint in UserSession::hasPermission() and User::hasPermission()

Yes.