The header for entity update lists seems too large.
Status report

There is a CSS rule that supposed to handle this but it is not applied because the system-status-report__entry class is no longer used in the corresponding template.

Issue fork drupal-3350387

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Chi created an issue. See original summary.

chi’s picture

Issue summary: View changes
gauravvvv’s picture

Status: Active » Needs review
StatusFileSize
new1.04 KB

I have updated the selector in the patch. please review

rinku jacob 13’s picture

Assigned: Unassigned » rinku jacob 13
rinku jacob 13’s picture

Assigned: rinku jacob 13 » Unassigned
akshay kashyap’s picture

@Gauravvvv Thanks for the work. I have applied your patch it's working fine

akshay kashyap’s picture

StatusFileSize
new47.56 KB
akshay kashyap’s picture

Status: Needs review » Reviewed & tested by the community
chi’s picture

"system-status-report__entry__value" class looks weird. It doesn't follow BEM naming convention.

rckstr_rohan made their first commit to this issue’s fork.

rohan-sinha’s picture

Status: Reviewed & tested by the community » Needs review

Assuming that the "system-status-report__entry__value" is a component or element of a larger system status report UI, I would name it using the BEM methodology as follows:

Block: system-status-report
Element: entry
Modifier: value

Thus, the complete BEM name for this element would be "system-status-report__entry--value".

chi’s picture

Modifier: value

I think "value" is not a modifier here but element. That template initially had weird class names. Fixing them is out of scope of this issue.

Patch #3 looks good. The only concern here is that element "system-status-report__entry__value" has no parent component.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Would agree with #13 but since it's currently not using a parent think it should be safe.

#3 fixed the issue.

larowlan’s picture

Removing credit for the MR, as there was already an RTBC patch beforehand

larowlan’s picture

Confirmed the existing template uses system-status-report__entry__value

larowlan’s picture

Not granting credit for the screenshots, which would have been useful, but unfortunately don't show a h3 element

here's some before/after shots with a hacked in h3 that was in caps in the source (ie the capitalization isn't from CSS).

This seems like a simple misnamed selector in the file, so going to commit.

larowlan’s picture

Title: Claro: fix size of H3 elements in status reprot » Claro: fix size of H3 elements in status report

Fixing typo

  • larowlan committed bc217933 on 10.0.x
    Issue #3350387 by Gauravvvv, Chi: Claro: fix size of H3 elements in...

  • larowlan committed a21a8cb7 on 10.1.x
    Issue #3350387 by Gauravvvv, Chi: Claro: fix size of H3 elements in...
larowlan’s picture

Version: 10.1.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 10.1.x and backported to 10.0.x and 9.5.x

  • larowlan committed 7dcaebdf on 9.5.x
    Issue #3350387 by Gauravvvv, Chi: Claro: fix size of H3 elements in...
drumm’s picture

(Updating to resolve Drupal.org issue indexing issue, please disregard)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.