Problem/Motivation

Remove unused variables [$resource,$key] from ResourceTest

    foreach ($manager->getDefinitions() as $resource => $definition) {
      foreach ($definition['uri_paths'] as $key => $uri_path) {
        $this->assertStringNotContainsString('//', $uri_path, 'The resource URI path does not have duplicate slashes.');
      }
    }


Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3338899_5.patch857 bytesnikhil_110

Issue fork drupal-3338899

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anmolgoyal74 created an issue. See original summary.

samaraof made their first commit to this issue’s fork.

samaraof opened merge request !3390

samaraof@ciandt.com’s picture

samaraof@ciandt.com commented

Hi , I'm opened a pull request for this change. Tests it's ok :)

nikhil_110’s picture

nikhil_110 commented
StatusFileSize
new 3338899_5.patch857 bytes

Remove unused variables for Patch Drupal 10.x

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Active » Needs review

@nikhil PR Is already created so we don't need patch now.
Moving it to needs review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Appears #5 is the same as the MR so removing credit for that as a reupload.

Change in MR 3390 seems fine.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3251754: Use DrupalPractice.CodeAnalysis.VariableAnalysis for Kernel and Unit tests

Thanks for working to improve Drupal core.

The changes here are coding standard changes which are done by rule and not by individual file. That will prevent future re-introductions of this problem. Coding standard fixes are being coordinated at #3319843: [Meta] Fix coding standards in core. For this particular issue, the work is being done in #3251754: Use DrupalPractice.CodeAnalysis.VariableAnalysis for Kernel and Unit tests. The changes here are already in the patch over there.

I'll make this a duplicate and move credit for the MR.