Use DrupalPractice.CodeAnalysis.VariableAnalysis for Kernel and Unit tests

The parent issue is committed so this can be worked on now.

A few more comments, mostly things that look like they can be removed entirely now.

No problem, and thanks for the fixes, looking pretty close now 👍

The MR looks good.

All the code changes look good to me.
The file core/phpcs.xml.dist has the exclude-pattern removed.
The testbot is happy.
For me it is RTBC.

RTBC +1

This needs to go on 10.0.x first.

@Spokje everything has to go into 10.x first because otherwise there is a future Drupal without this fixed. And yes it applies to all coding standards patches currently rtbc.

Reuploading patch for 9.4.x, rerolled for 10.0.x.

NW following #3174402: Fix unused variable $unpublished in TrackerTest.php

Also not sure why PHPStan is failing on AssertHelperTraitTest, maybe a symptom of #3259355: Always do a full phpstan analysis on DrupalCI?

Testing if phpstan causes the problem here.

PHPstan gives same result on both partial and full scan.

In our phpstan config we have

excludePaths:
# Skip test fixtures.
- */tests/fixtures/*.php

This skips the AssertHelperTestClass class.

AssertHelperTraitTest and the fixture will anyway be removed with #3261266: Remove deprecated code from the testing framework (base classes, listeners, etc), so we may want to postpone this on that

+++ b/core/modules/tracker/tests/src/Functional/TrackerTest.php
@@ -388,7 +388,7 @@ public function testTrackerCronIndexing() {
-    $unpublished = $this->drupalCreateNode([
+    $this->drupalCreateNode([

This is no longer unused.

Closed #3338899: Remove unused variables [$resource,$key] from ResourceTest as a duplicate, adding credit.

Adding parent.

Discussed this longwave and they suggested a different parent. I am changing the parent now. I will add a comment to the previous parent since this is using a sniff.

Change parent to the meta implementing this sniff.

While working on this I found two tests that seem to have lost test coverage from earlier changes. Because of that and the size of this was growing I decided to split this up.

There is an error on core/modules/views/tests/src/Unit/Controller/ViewAjaxControllerTest.php

Drupal\Tests\views\Unit\Controller\ViewAjaxControllerTest::testAjaxView
TypeError: Drupal\Tests\views\Unit\Controller\ViewAjaxControllerTest::setupValidMocks(): Return value must be of type array, MockObject_ViewExecutable_903e6638 returned

core/modules/views/tests/src/Unit/Controller/ViewAjaxControllerTest.php:435
core/modules/views/tests/src/Unit/Controller/ViewAjaxControllerTest.php:197

because setupValidMocks has a return type hint of array but it does not return an array. It returns a mock. Changed in #3458427: Add array return typehints to protected test helper methods

Appears to be a pretty valid open question.

When I opened the current implementation of core/modules/field/tests/src/Unit/Plugin/migrate/process/d6/FieldInstanceSettingsTest.php I actually see that $migration is flagged as an unused variable

Believe feedback has been addressed for this one.

NW for some additional removals and also a question about the configuration file.

Thanks for the reviews.

Removed the suggestions, had to re-run tests 2 times for random failures.

Committed 0635e0d and pushed to 11.x. Thanks!