Return early if syslog configs are NULL to avoid openlog deprecation

patch for drupal 10.1.x

I am updating tags according to the guidelines.

This is opened as a support request, which means code offered here will not be incorporated into Drupal. Is it actually a bug report? If so, can you please list the steps to reproduce it? Which module is passing nulls?

It's not expected for the prefix (aka identity) or facility config to be NULL, as these are created as string and integer configs, respectively. That said, it is technically possible for a config to be NULL since it could be forcibly deleted e.g. via drush.

I would say if either of these configs are unexpectedly NULL, it's best to not call openlog() at all, and log a more severe warning or error message rather than this deprecated notice. But if this is a super rare scenario then not sure it's worth spending the time to work on a patch..

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

I had the same issue described here in a dev site and patch in #11 solved the question

Rerolled the patch and Created the MR.

Will need a test case showing the issue.

I had the same error on my page after updating to PHP 8.1 and Drupal 9.5.7 when I submitted a webform. the patch in #11 solved the problem

I tried to replicate this with Drupal 9.5.x and 10.x. In both scenarios, the default value for 'identity' is set to drupal. And this has been the case since 2012 according to git log.

If you submit the form UI for syslog with no identity, it fallbacks to an empty string.

As @mfb said https://www.drupal.org/project/drupal/issues/3333215#comment-14868399 the only way this can happen is by either, editing the identity using drush cedit, or by manually removing the identity value from the config file and running drush config sync.

This seems more a won't fix to me than forcing the value of openlog.

Have the same error after updating to php 8.1.20 and drupal core 9.5.8
We set the identiy from settings.php, as we run more than 100 sites with the same drupal build, with:

$config['system.logging']['error_level'] = 'all';
$config['syslog.settings']['identity'] = 'replaced name of current site';
$config['syslog.settings']['format'] = '!base_url|!timestamp|!type|!ip|!request_uri|!referer|!uid|!link|!message';

After a drush cr is run the first visitor would se the red deprecation warning.
Therefore I would upvote for this to be fixed in core.

It sounds like folks are hitting edge cases where format is set, but facility or identity (prefix) is not set. Syslog module only checks if format exists before logging, but not the other configs. So if you have format set, but not facility or identity (prefix), then you hit this "deprecated" message.

Here's a patch w/ the extra logic to also check facility and identity (prefix) before logging.

Update steps to reproduce and proposed resolution.

Ran the test locally without the fix and got

Failed asserting that file "vfs://root/sites/simpletest/62868829/files/syslog.log" does not exist.

Additional check seems to be good and matches issue summary.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Somehow it will not apply for version ^10.1 and I have to generate new patch.

Sorry, uploaded wrong patch, here is the right one.

@Alen Simonyan this issue was already resolved in the 10.1 branch, so you don't need to apply a patch

Ahh, ok, thanks @mfb, didn't notice